[REFACTOR] AI 서버 API 스펙 변경으로 인한 코드 수정 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the client API requests to align with the updated AI API specifications by modifying request and response structures and updating corresponding service calls.
- Updated DTOs to use detailed recommendation objects instead of simple answer strings.
- Adjusted the API client methods and service handling to accommodate the new request object structure.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/hyu/erica/capstone/web/dto/client/StyleRequestDTO.java | New DTO for style requests with a static factory method |
| src/main/java/hyu/erica/capstone/web/dto/client/RestaurantRequestDTO.java | Revised to include detailed recommendation records |
| src/main/java/hyu/erica/capstone/web/dto/client/AttractionRequestDTO.java | Revised to include detailed recommendation records; contains an unused import |
| src/main/java/hyu/erica/capstone/service/async/StyleBackgroundTaskService.java | Updated to create a StyleRequestDTO instead of a prompt string |
| src/main/java/hyu/erica/capstone/client/PlanClient.java | Updated API endpoints to use POST with a request body |
Comments suppressed due to low confidence (1)
src/main/java/hyu/erica/capstone/service/async/StyleBackgroundTaskService.java:58
- [nitpick] The variable name 'prompt' is misleading now that it holds a StyleRequestDTO object; consider renaming it to 'styleRequest' for clarity.
StyleRequestDTO prompt = StyleRequestDTO.of(style.getCity().name(), style.getStartDate(),
| @@ -1,6 +1,11 @@ | |||
| package hyu.erica.capstone.web.dto.client; | |||
|
|
|||
| import jakarta.persistence.criteria.CriteriaBuilder.In; | |||
There was a problem hiding this comment.
The import 'jakarta.persistence.criteria.CriteriaBuilder.In' is not used in the code; please remove it to clean up the file.
Suggested change
| import jakarta.persistence.criteria.CriteriaBuilder.In; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
#35
🔎 작업 내용