Skip to content

Conversation

@msk226
Copy link
Member

@msk226 msk226 commented Apr 7, 2025

#️⃣ 연관된 이슈

#37


🔎 작업 내용

  1. 내 여행 계획 리스트 조회 기능 구현

📷 스크린샷 (선택)

작업한 결과물에 대한 간단한 스크린샷을 올려주세요.


💬리뷰 요구사항 (선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요.

@msk226 msk226 added the feature 기능 구현 label Apr 7, 2025
@msk226 msk226 requested a review from Copilot April 7, 2025 04:13
@msk226 msk226 self-assigned this Apr 7, 2025
@msk226 msk226 linked an issue Apr 7, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comment on lines +32 to +33
int dayDiff = (int) (LocalDate.now().toEpochDay() - endDate.toEpochDay());

Copy link

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The computation for dayDiff subtracts the trip's endDate from the current date, which may result in negative values if the trip has not ended yet. Consider revising the calculation to 'endDate.toEpochDay() - LocalDate.now().toEpochDay()' to represent the remaining days until the trip ends.

Suggested change
int dayDiff = (int) (LocalDate.now().toEpochDay() - endDate.toEpochDay());
int dayDiff = (int) (endDate.toEpochDay() - LocalDate.now().toEpochDay());

Copilot uses AI. Check for mistakes.
@msk226 msk226 merged commit 50ab590 into develop Apr 7, 2025
1 check passed
@msk226 msk226 deleted the feature/37 branch April 7, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature 기능 구현

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] 마이페이지 관련 기능 구현

2 participants