Skip to content

Conversation

@msk226
Copy link
Member

@msk226 msk226 commented Apr 29, 2025

#️⃣ 연관된 이슈

#47


🔎 작업 내용

  • 추천받은 여행지 및 식당을 수정 및 삭제 하는 API 구현

📷 스크린샷 (선택)

작업한 결과물에 대한 간단한 스크린샷을 올려주세요.


💬리뷰 요구사항 (선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요.

@msk226 msk226 linked an issue Apr 29, 2025 that may be closed by this pull request
@msk226 msk226 self-assigned this Apr 29, 2025
@msk226 msk226 requested a review from Copilot April 29, 2025 04:59
@msk226 msk226 added the feature 기능 구현 label Apr 29, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request implements APIs for editing recommended attractions and restaurants on a trip plan. The changes include new endpoints in the controller for editing attractions and restaurants, corresponding service method implementations to update preference records, and repository methods to support the new functionality.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/java/hyu/erica/capstone/web/controller/TripPlanController.java Added new PUT endpoints for editing attractions and restaurants
src/main/java/hyu/erica/capstone/service/tripPlan/impl/TripPlanCommandServiceImpl.java Implemented service methods to update recommendations based on API input
src/main/java/hyu/erica/capstone/service/tripPlan/TripPlanCommandService.java Extended the interface with new editing methods
src/main/java/hyu/erica/capstone/repository/PreferRestaurantRepository.java Added repository method for restaurant existence check
src/main/java/hyu/erica/capstone/repository/PreferAttractionRepository.java Added repository method for attraction existence check
Comments suppressed due to low confidence (2)

src/main/java/hyu/erica/capstone/web/controller/TripPlanController.java:145

  • [nitpick] Consider using a consistent name such as 'tripPlanId' instead of 'tripPlansId' for clarity and consistency with other parts of the codebase.
public ApiResponse<?> editPlaces(@PathVariable Long tripPlansId, @RequestBody SaveAttractionRequestDTO request) {

src/main/java/hyu/erica/capstone/service/tripPlan/impl/TripPlanCommandServiceImpl.java:119

  • [nitpick] Consider aligning the parameter name to 'tripPlanId' to maintain consistency with other method signatures and repository calls.
public void editAttractionRecommendation(Long tripPlansId, SaveAttractionRequestDTO request) {

@msk226 msk226 merged commit a80721c into develop Apr 29, 2025
1 check passed
@msk226 msk226 deleted the feature/47 branch April 29, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature 기능 구현

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] 선택지 수정 및 삭제 API 구현

2 participants