-
Notifications
You must be signed in to change notification settings - Fork 99
chore: support flutter 3.29 #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: support flutter 3.29 #207
Conversation
|
@peilinok Please help me take a look |
|
Hi @locandpad , We greatly appreciate your contribution to this project. However, we regret to inform you that this Pull Request cannot be merged due to testing concerns. While we plan to address broader compatibility considerations in RTM version 2, for RTM version 1, we recommend maintaining a private fork where you can implement these changes as needed. The primary concern is that the proposed Android Gradle Plugin (AGP) and Gradle version upgrades are too substantial, which could cause compilation issues for clients who maintain older Flutter versions. |
|
@peilinok this is also blocking us from upgrading our Flutter version, there's still no migration guide to RTM 2 for this Flutter package after 7 months since its release |
You can refer to native doc for migration, it's pretty similar in Flutter https://docs.agora.io/en/signaling/overview/migration-guide?platform=android What they don't tell you is that RTM 2.x is not fully backward compatible with 1.x. If you are using the |
|
@locandpad could you rebase this on top of latest |
a73caee to
c42976e
Compare
|
@peilinok Android 16k page sizes requirement coming November 1st, do you have any plan to support it on RTM1 or do we need to migrate to 2.x ? |
|
@locandpad version 1.6.3 has 16KB support, since this is still not merged, can you rebase from latest |
|
@peilinok version 1.6.3 from pub.dev doesn't compile as-is with Flutter 3.32.8, could you also check that? |
RTM 1 and RTM 2 is not fully compatible, therefore, developers stucked on RTM 1 cannot update to latest Flutter due to issues below:
Tested and run ok on Flutter 3.29.3