Simplify code: Fix typos, refactor logic, and remove unused parameters. #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Claudenw
requested changes
Jul 29, 2025
| @@ -115,7 +115,7 @@ public static <T, E extends Exception> T callWithRetry(final String callName, fi | |||
| final long sleepTimeMs = computeRandomRetryWaitTimeInMillis(retryAttempts, retryBackoffMs); | |||
| final var msg = String.format("Failed to %s with attempt %s/%s, will attempt retry after %s ms. ", | |||
| callName, attempts, maxAttempts, sleepTimeMs); | |||
| LOGGER.warn(msg + "Failure reason: {}", e); | |||
| LOGGER.warn(msg + "Failure reason: ", e); | |||
There was a problem hiding this comment.
This should probably be:
LOGGER.warn("{} Failure reason {}", msg, e.getMessage(), e);
or something similar. Perhaps just
LOGGER.warn(msg, e);
Comment on lines
35
to
+39
| final Collection<OpensearchClientConfigurator> configurators = new ArrayList<>(); | ||
| final ServiceLoader<OpensearchClientConfigurator> loaders = ServiceLoader | ||
| .load(OpensearchClientConfigurator.class, ClientsConfiguratorProvider.class.getClassLoader()); | ||
|
|
||
| final Iterator<OpensearchClientConfigurator> iterator = loaders.iterator(); | ||
| while (iterator.hasNext()) { | ||
| final OpensearchClientConfigurator configurator = iterator.next(); | ||
| for (OpensearchClientConfigurator configurator : loaders) { |
There was a problem hiding this comment.
This could be replaced with
return ServiceLoader
.load(OpensearchClientConfigurator.class, ClientsConfiguratorProvider.class.getClassLoader()).stream().collect(Collectors.toList());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves code quality by:
I found this project while looking into Kafka connectors. It's really impressive, thanks☺️