Skip to content

Conversation

gustavo-shigueo
Copy link
Collaborator

Goal

Fix issue that prevents projects that use ts-rs with the format feature from building.
Closes #437

Changes

Updated dprint-plugin-typescript to version 0.95 after testing versions 0.90, 0.91, 0.92, 0.93 and 0.94, all of which still triggered the issue

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@gustavo-shigueo gustavo-shigueo added the breaking change This PR will change the public API in some way label Sep 19, 2025
@gustavo-shigueo gustavo-shigueo added the bug Something isn't working label Sep 23, 2025
@bakr-dev
Copy link

bakr-dev commented Oct 7, 2025

Hi @gustavo-shigueo and @NyxCode , thank you for your work on this fix!

Just wanted to add that my project is also affected by this compilation bug, and I'm really looking forward to this patch being merged.

Is there anything I can do to help with testing or validation to move this forward?

Thanks again!

@NyxCode
Copy link
Collaborator

NyxCode commented Oct 7, 2025

Thanks! I'm not sure if we should make this a breaking change. I think we shouldn't, especially since 1.88 isn't bleeding-edge and the feature is optional anyway.

NyxCode
NyxCode previously approved these changes Oct 7, 2025
@gustavo-shigueo
Copy link
Collaborator Author

Hey @NyxCode! To avoid flagging this as a breaking change we could lower the MSRV back to its previous value and then change the CI MSRV validation to not check the format feature

@NyxCode
Copy link
Collaborator

NyxCode commented Oct 7, 2025

Hm, why not just publish this fix as v11.1?

@gustavo-shigueo
Copy link
Collaborator Author

gustavo-shigueo commented Oct 7, 2025

I think the MSRV field would prevent projects with Rust < 1.88 from compiling, even if they don't use format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This PR will change the public API in some way bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Latest version fails to build with format feature.

3 participants