-
Notifications
You must be signed in to change notification settings - Fork 135
Fix build with format
feature
#438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @gustavo-shigueo and @NyxCode , thank you for your work on this fix! Just wanted to add that my project is also affected by this compilation bug, and I'm really looking forward to this patch being merged. Is there anything I can do to help with testing or validation to move this forward? Thanks again! |
Thanks! I'm not sure if we should make this a breaking change. I think we shouldn't, especially since 1.88 isn't bleeding-edge and the feature is optional anyway. |
Hey @NyxCode! To avoid flagging this as a breaking change we could lower the MSRV back to its previous value and then change the CI MSRV validation to not check the format feature |
Hm, why not just publish this fix as v11.1? |
I think the MSRV field would prevent projects with Rust |
Goal
Fix issue that prevents projects that use
ts-rs
with theformat
feature from building.Closes #437
Changes
Updated
dprint-plugin-typescript
to version0.95
after testing versions0.90
,0.91
,0.92
,0.93
and0.94
, all of which still triggered the issueChecklist