Skip to content

Conversation

eviefp
Copy link

@eviefp eviefp commented Aug 20, 2025

Sorting workspaces by output works really well with 'active-only' and 'all-outputs' with multi-monitor setups, allowing to keep the order of the buttons while swapping workspaces.

Copy link
Contributor

@zjeffer zjeffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the docs

@eviefp
Copy link
Author

eviefp commented Aug 24, 2025

What do you mean by docs? The Wiki, or did I miss some docs in the repo itself?

And if yes, I assume I'll need to update the wiki after this is merged? Or?

@zjeffer
Copy link
Contributor

zjeffer commented Aug 24, 2025

You have to update this file: https://github.com/Alexays/Waybar/blob/master/man/waybar-hyprland-workspaces.5.scd

After it's merged, you can also update this wiki page: https://github.com/Alexays/Waybar/wiki/Module:-Hyprland

@eviefp
Copy link
Author

eviefp commented Aug 26, 2025

Oh, I did edit that file actually, see https://github.com/Alexays/Waybar/pull/4400/files#diff-19fcfa11dfbb35133193b000f1f88e5c337171946f2011a44c39f9cf3741cb7dR117

Happy to add more if needed. I didn't because it doesn't feel like this option needs that much more attention than a line there.

@zjeffer
Copy link
Contributor

zjeffer commented Aug 26, 2025

Oops, not sure how I read over that haha

LGTM

@eviefp
Copy link
Author

eviefp commented Oct 5, 2025

Rebased/fixed merge conflicts. Soft nudge to @Alexays in case that's why this hasn't gotten merged with the recent batch of merges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants