-
Notifications
You must be signed in to change notification settings - Fork 153
[ACS-10083] Filter not behaving correctly in file and site #4817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
projects/aca-content/src/lib/components/files/files.component.spec.ts
Outdated
Show resolved
Hide resolved
projects/aca-content/src/lib/components/files/files.component.spec.ts
Outdated
Show resolved
Hide resolved
@AleksanderSklorz , Screen.Recording.2025-10-06.at.13.07.47.movSo the reason for that is that we have 2 APIs to work with folders - Search API and Nodes API ('/nodes/{nodeId}/children' endpoint). I've examined several options:
I suggest create dedicated ticket for exploring option with additional loader indicator. It would require some refactoring cc @MichalKinas |
Hi @rmnvch. My comment is still but not here. It's in alfresco-applications repository: Regarding to solution: by "extend loader indicator" you mean adding something like "loading spinner" there, right? Yes, it makes sense for me. If you need more time you can do it as part of that PR, it's fine or you can create separate ticket if you prefer do it as separated one. In case you want to do it as separated task then please create jira task and add link to that task as comment here in PR |
7ba4160
to
7b8470b
Compare
@rmnvch I see now those filters don't work properly, for example - I select folder filter but I can't see anything. Folder should be displayed in that case: Screen.Recording.2025-10-13.at.11.45.19.mov |
projects/aca-content/src/lib/components/files/files.component.ts
Outdated
Show resolved
Hide resolved
|
@AleksanderSklorz , hey. I believe it's temporary issue due to API's 500 error. I've encountered that last week too Uploading sample error.mov… |
@AleksanderSklorz , I've finished updates. the changes are mainly in ADF's PR. Alfresco/alfresco-ng2-components#11237 |
@rmnvch it works better now but found one more problem. When you select both checkboxes and refresh page then you can't see anything. When you change page after reloading for example to libraries and you will return to personal files then page is broken as well: Screen.Recording.2025-10-15.at.10.59.03.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmnvch please fix new found issue:
#4817 (comment)
@AleksanderSklorz , thanks for pointing that out, my bad. fixed in ADF's PR. |
JIRA ticket link or changeset's description
https://hyland.atlassian.net/browse/ACS-10083
relates to:
ADF PR:
Alfresco/alfresco-ng2-components#11237
blocks ADW PR:
https://github.com/Alfresco/alfresco-applications/pull/1258