Skip to content

Conversation

rmnvch
Copy link
Contributor

@rmnvch rmnvch commented Sep 30, 2025

@rmnvch
Copy link
Contributor Author

rmnvch commented Oct 6, 2025

@AleksanderSklorz ,
for some reason your initial comment has gone. The issue was connected to lag after page reload with queryParams - filters are applied after initial API call:

Screen.Recording.2025-10-06.at.13.07.47.mov

So the reason for that is that we have 2 APIs to work with folders - Search API and Nodes API ('/nodes/{nodeId}/children' endpoint). I've examined several options:

  • Migrate to Nodes API fully. It can be used with folders/files filtering, but Nodes API has limits in terms of filtering be text queries - it supports only EQUALS operator in queries ('where' parameter) and cannot be used to filter according text queries - 'LIKE' or 'CONTAINS' are not supported as confirmed with BE team.
  • Extend loader indicator. Filters are initiated after initial data is loaded, it means that table should be showed to make additional request.

I suggest create dedicated ticket for exploring option with additional loader indicator. It would require some refactoring

cc @MichalKinas

@AleksanderSklorz
Copy link
Contributor

AleksanderSklorz commented Oct 6, 2025

@AleksanderSklorz , for some reason your initial comment has gone. The issue was connected to lag after page reload with queryParams - filters are applied after initial API call:

Screen.Recording.2025-10-06.at.13.07.47.mov
So the reason for that is that we have 2 APIs to work with folders - Search API and Nodes API ('/nodes/{nodeId}/children' endpoint). I've examined several options:

  • Migrate to Nodes API fully. It can be used with folders/files filtering, but Nodes API has limits in terms of filtering be text queries - it supports only EQUALS operator in queries ('where' parameter) and cannot be used to filter according text queries - 'LIKE' or 'CONTAINS' are not supported as confirmed with BE team.
  • Extend loader indicator. Filters are initiated after initial data is loaded, it means that table should be showed to make additional request.

I suggest create dedicated ticket for exploring option with additional loader indicator. It would require some refactoring

cc @MichalKinas

Hi @rmnvch. My comment is still but not here. It's in alfresco-applications repository:
https://github.com/Alfresco/alfresco-applications/pull/1258#issuecomment-3355208593

Regarding to solution: by "extend loader indicator" you mean adding something like "loading spinner" there, right? Yes, it makes sense for me. If you need more time you can do it as part of that PR, it's fine or you can create separate ticket if you prefer do it as separated one. In case you want to do it as separated task then please create jira task and add link to that task as comment here in PR

@rmnvch rmnvch force-pushed the ACS-10083-decode-query branch from 7ba4160 to 7b8470b Compare October 13, 2025 09:20
@AleksanderSklorz
Copy link
Contributor

@rmnvch I see now those filters don't work properly, for example - I select folder filter but I can't see anything. Folder should be displayed in that case:

Screen.Recording.2025-10-13.at.11.45.19.mov

Copy link

@rmnvch
Copy link
Contributor Author

rmnvch commented Oct 13, 2025

@rmnvch I see now those filters don't work properly, for example - I select folder filter but I can't see anything. Folder should be displayed in that case:

Screen.Recording.2025-10-13.at.11.45.19.mov

@AleksanderSklorz , hey. I believe it's temporary issue due to API's 500 error. I've encountered that last week too

Uploading sample error.mov…

@rmnvch
Copy link
Contributor Author

rmnvch commented Oct 13, 2025

@AleksanderSklorz , for some reason your initial comment has gone. The issue was connected to lag after page reload with queryParams - filters are applied after initial API call:
Screen.Recording.2025-10-06.at.13.07.47.mov
So the reason for that is that we have 2 APIs to work with folders - Search API and Nodes API ('/nodes/{nodeId}/children' endpoint). I've examined several options:

  • Migrate to Nodes API fully. It can be used with folders/files filtering, but Nodes API has limits in terms of filtering be text queries - it supports only EQUALS operator in queries ('where' parameter) and cannot be used to filter according text queries - 'LIKE' or 'CONTAINS' are not supported as confirmed with BE team.
  • Extend loader indicator. Filters are initiated after initial data is loaded, it means that table should be showed to make additional request.

I suggest create dedicated ticket for exploring option with additional loader indicator. It would require some refactoring
cc @MichalKinas

Hi @rmnvch. My comment is still but not here. It's in alfresco-applications repository: Alfresco/alfresco-applications#1258 (comment)

Regarding to solution: by "extend loader indicator" you mean adding something like "loading spinner" there, right? Yes, it makes sense for me. If you need more time you can do it as part of that PR, it's fine or you can create separate ticket if you prefer do it as separated one. In case you want to do it as separated task then please create jira task and add link to that task as comment here in PR

@AleksanderSklorz , I've finished updates. the changes are mainly in ADF's PR. Alfresco/alfresco-ng2-components#11237

@AleksanderSklorz
Copy link
Contributor

@rmnvch it works better now but found one more problem. When you select both checkboxes and refresh page then you can't see anything. When you change page after reloading for example to libraries and you will return to personal files then page is broken as well:

Screen.Recording.2025-10-15.at.10.59.03.mov

Copy link
Contributor

@AleksanderSklorz AleksanderSklorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmnvch please fix new found issue:
#4817 (comment)

@rmnvch
Copy link
Contributor Author

rmnvch commented Oct 15, 2025

@rmnvch please fix new found issue: #4817 (comment)

@AleksanderSklorz , thanks for pointing that out, my bad. fixed in ADF's PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants