[ACS-9224] [ACS-9227] Fixed critical accessibility issues in datatable component #10778
+28
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atable.component.html
swapnil-verma-gl
requested review from
AleksanderSklorz,
MichalKinas,
dominikiwanekhyland and
nikita-web-ua
swapnil-verma-gl
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
|
nikita-web-ua
approved these changes
Apr 10, 2025
AleksanderSklorz
approved these changes
Apr 10, 2025
DenysVuika
requested changes
Apr 22, 2025
|
|
||
| <!-- Columns --> | ||
| <div *ngIf="multiselect" class="adf-datatable-cell-header adf-datatable-checkbox"> | ||
| <th *ngIf="multiselect" class="adf-datatable-cell-header adf-datatable-checkbox" role="columnheader"> |
There was a problem hiding this comment.
There was a PR doing exactly the opposite recently, and we removed th/tr from here... so I suggest checking the history and contacting the corresponding devs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Datatable component had 2 accessibility issues reported by axeDevTools
What is the new behaviour?
Resolved accessibility issues
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-9224
https://hyland.atlassian.net/browse/ACS-9227