Skip to content

Conversation

dominikiwanekhyland
Copy link
Contributor

…Auth

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/MNT-25336

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

ticket = requestUrl.indexOf(ecmRoot) < requestUrl.indexOf(bpmRoot) ? this.getContentServicesTicket() : this.getProcessServicesTicket();
return requestUrl.indexOf(ecmRoot) < requestUrl.indexOf(bpmRoot) ? this.getContentServicesTicket() : this.getProcessServicesTicket();
} else {
return this.getContentServicesTicket();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just thinking if that's the right solution, in that case every request outside ecmRoot or bpmRoot will receive content services ticket and I don't really think we want to do this, I wonder if this wouldn't be safer to rather add additional case for OOI connector rather then add it to every other request, @AleksanderSklorz what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, good point Michał. I agree with you that it will be safer, especially that in previous version we returned null for that case so we don't know what consequences this will cause if now we will be always that in this case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AleksanderSklorz @MichalKinas I thought it will be cleaner not to implement any login required for OOI Connector into ADF, but sure, I have updated my PR after your comments. THanks :)

Copy link

sonarqubecloud bot commented Oct 1, 2025

@dominikiwanekhyland dominikiwanekhyland merged commit dffa37f into develop Oct 1, 2025
18 checks passed
@dominikiwanekhyland dominikiwanekhyland deleted the MNT-25336-adw-cant-start-a-microsoft-365-session-when-using-basic-auth branch October 1, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants