-
Notifications
You must be signed in to change notification settings - Fork 277
[MNT-25336] ADW can't start a Microsoft 365 session when using Basic … #11238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT-25336] ADW can't start a Microsoft 365 session when using Basic … #11238
Conversation
lib/core/src/lib/auth/basic-auth/basic-alfresco-auth.service.ts
Outdated
Show resolved
Hide resolved
ticket = requestUrl.indexOf(ecmRoot) < requestUrl.indexOf(bpmRoot) ? this.getContentServicesTicket() : this.getProcessServicesTicket(); | ||
return requestUrl.indexOf(ecmRoot) < requestUrl.indexOf(bpmRoot) ? this.getContentServicesTicket() : this.getProcessServicesTicket(); | ||
} else { | ||
return this.getContentServicesTicket(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just thinking if that's the right solution, in that case every request outside ecmRoot or bpmRoot will receive content services ticket and I don't really think we want to do this, I wonder if this wouldn't be safer to rather add additional case for OOI connector rather then add it to every other request, @AleksanderSklorz what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good point Michał. I agree with you that it will be safer, especially that in previous version we returned null for that case so we don't know what consequences this will cause if now we will be always that in this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AleksanderSklorz @MichalKinas I thought it will be cleaner not to implement any login required for OOI Connector into ADF, but sure, I have updated my PR after your comments. THanks :)
|
…Auth
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/MNT-25336
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: