Skip to content

Conversation

@nikita-web-ua
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe: a11y

What is the current behaviour? (You can also link to an open issue here)

https://hyland.atlassian.net/browse/ACS-10236
https://hyland.atlassian.net/browse/ACS-10271

What is the new behaviour?

Screenshot 2025-10-24 at 08 51 54

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@MichalKinas MichalKinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes look good to me, please remember to fix the SonarCloud issues

@AleksanderSklorz
Copy link
Contributor

AleksanderSklorz commented Oct 24, 2025

@nikita-web-ua not sure if that is issue only on my local but this requirement from this task https://hyland.atlassian.net/browse/ACS-10236 seems not fixed:

image

There is never mentioned that "File Size" group's name when I enter into any field

@nikita-web-ua
Copy link
Contributor Author

@nikita-web-ua not sure if that is issue only on my local but this requirement from this task https://hyland.atlassian.net/browse/ACS-10236 seems not fixed:

image There is never mentioned that "File Size" group's name when I enter into any field

@AleksanderSklorz it works for me, it just announce group on the first selected element of this group, as far as I checked this is expected behaviour as assistive technologies like screen readers typically announce the group label only when the user first navigates into the group.

Screenshot 2025-10-24 at 11 38 41 Screenshot 2025-10-24 at 11 39 35

@AleksanderSklorz
Copy link
Contributor

@nikita-web-ua I found one more thing, Quantity field seems not read sometimes:

Screen.Recording.2025-10-24.at.11.41.25.mov

@nikita-web-ua
Copy link
Contributor Author

@nikita-web-ua I found one more thing, Quantity field seems not read sometimes:

Screen.Recording.2025-10-24.at.11.41.25.mov

fixed, ty

@sonarqubecloud
Copy link

@nikita-web-ua nikita-web-ua merged commit 160b129 into develop Oct 24, 2025
18 checks passed
@nikita-web-ua nikita-web-ua deleted the dev-mmaliarchuk/ACS-10271-add-labels-to-search-filters branch October 24, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants