Fix some lint hints from the package very_good_analysis #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-blank
changed the title
|
@devrahul-2508 short update, just in case: I messed up a bit and developed my addition on the master branch, so they showed up in this PR aswell until now. I created a new branch, so now this PR only contains the changes that I want to contribute back initially. Again, thanks for your great work! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
First of, thank you very much for this repository! I am currently building some tracker app for my Android phone and for that I needed to be able to enter data without unlocking my phone. It has been quite some time that I did something with mobile development, so having this project available saved me a ton of work!! :)
I've submitted this PR to fix some linting issues I encountered while setting up the project. I'm planning to fork this as a base for my tracker app. I cleaned them up for my own work, and thought I'd offer the lint fixes back in case you find them useful too.
As for testing, I tested it manually on my pixel phone.
Again, thanks a lot!