core: If a user specifies --no-gui, don't show GUI messageboxes #5514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
NewSoupVi
reviewed
Oct 5, 2025
| from NetUtils import (Endpoint, decode, NetworkItem, encode, JSONtoTextParser, ClientStatus, Permission, NetworkSlot, | ||
| RawJSONtoTextParser, add_json_text, add_json_location, add_json_item, JSONTypes, HintStatus, SlotType) | ||
| from Utils import Version, stream_input, async_start | ||
| from Utils import gui_enabled, Version, stream_input, async_start |
There was a problem hiding this comment.
I think your changes are sensible, but I'm a bit confused about this original Treble stuff.
Imo, there are two possibilities:
- This should be
from Utils import gui_enabled as gui_enabled - Clients are "meant" to switch over to
from Utils import gui_enabled, in which case this should get an API Updates ping
Reason: Relying on implicit reexporting is bad™️ (It fails mypy, for example, i.e. this change would implicitly make mypy-compliant worlds fail mypy without their knowledge)
I would like us to be clear about what the intent is here
There was a problem hiding this comment.
Yep, 100% agree with that.
My gut prefers the second option?
benny-dreamly
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Utils.messagebox is called directly from various places within core code. This means that if an individual client wants to use those functions while in nogui mode, it will end up popping a GUI messagebox (or worse, crashing with "ModuleNotFoundError: No module named 'tkinter'").
This PR is based on alwaysintreble's work in #4925 and adds a
gui_enabledcheck toUtils.messagebox, falling back to aLoggingcall if the user specified--nogui.How was this tested?
python .\Launcher.py worldman -- --update-all --nogui. This loops throughLauncherComponents.install_apworldwhich attempts to show a messagebox per install.python .\Launcher.py "BizHawk Client" -- corrupt_patch.apemerald --nogui(A hand-mangled Emerald patch), which calls Utils.messagebox if it fails to patch the game.If this makes graphical changes, please attach screenshots.