SC2: Fix the goal mission tooltip depending on goal missions' status #5577
+31
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ziktofel
added
the
is: bug/fix
github-actions
bot
added
the
waiting-on: peer-review
Snarkie
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
Code looks good, as far as I can tell, changes make sense.
Tested on my end, opened a custom mission order with multiple goal missions and checked the different states for goal missions and their respective tooltips. Definitely more clear, should lead to less confusion when Victory Locations get collected.
MatthewMarinets
approved these changes
Oct 23, 2025
|
Failed test appears to be caused by Super Mario 64 |
|
Notified in the Discord the SM64 maintainer |
Ziktofel
added
waiting-on: core-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes the tooltip of goal missions when all the goal missions were collected (for example by goaling an another world) to provide the correct instructions how to beat the world (you need to beat a goal mission yourself to goal your own world, thus no chain-goaling)
How was this tested?
Launched the client and hovered over the goal mission under different conditions
If this makes graphical changes, please attach screenshots.
Only text changes. Verified that the whitespaces are displayed as intended