Skip to content

test(flight_controller_info): raise abstraction and coverage level #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

test(flight_controller_info): raise abstraction and coverage level #974

merged 1 commit into from
Oct 28, 2025

Conversation

@amilcarlucas
Copy link
Collaborator

No description provided.

@amilcarlucas
test(flight_controller_info): raise abstraction and coverage level
51126cf 
pylint fixes in test_frontend_tkinter_software_update.py are required
as a side effect of the flightcontroller_info changes
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

Test Results

    2 files  ±0      2 suites  ±0   1m 53s ⏱️ +4s
1 975 tests +3  1 975 ✅ +3  0 💤 ±0  0 ❌ ±0 
3 950 runs  +6  3 950 ✅ +6  0 💤 ±0  0 ❌ ±0 

Results for commit 7bc0727. ± Comparison against base commit 0322097.

This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both. 
tests.test_frontend_tkinter_flightcontroller_info.TestFlightControllerParameterWorkflow ‑ test_user_receives_none_when_no_parameters_downloaded
tests.test_frontend_tkinter_flightcontroller_info.TestFlightControllerParameterWorkflow ‑ test_user_sees_accurate_progress_tracking_during_parameter_download

tests.test_frontend_tkinter_flightcontroller_info.TestFlightControllerInfoProgressBarErrorHandling ‑ test_user_sees_graceful_handling_when_progress_bar_widgets_are_destroyed
tests.test_frontend_tkinter_flightcontroller_info.TestFlightControllerInfoProgressBarErrorHandling ‑ test_user_sees_graceful_handling_when_window_lift_fails_due_to_tcl_error
tests.test_frontend_tkinter_flightcontroller_info.TestFlightControllerInfoProgressBarErrorHandling ‑ test_user_sees_progress_bar_hidden_when_download_completes
tests.test_frontend_tkinter_flightcontroller_info.TestFlightControllerInfoWindowInitialization ‑ test_user_experiences_proper_window_initialization_and_setup
tests.test_frontend_tkinter_flightcontroller_info.TestFlightControllerParameterWorkflow ‑ test_user_receives_empty_parameter_defaults_when_no_parameters_downloaded

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8729 7405 85% 80% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 51126cf by action🐍

@amilcarlucas amilcarlucas force-pushed the url_fallback branch 2 times, most recently from 7bc0727 to 51126cf Compare October 28, 2025 09:59
@amilcarlucas amilcarlucas merged commit 83b2817 into master Oct 28, 2025
31 of 32 checks passed
@amilcarlucas amilcarlucas deleted the url_fallback branch October 28, 2025 12:15
@amilcarlucas amilcarlucas mentioned this pull request Oct 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amilcarlucas