Skip to content

Untangling: Replace Calypso stats menu w WP-Admin version #44524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

BogdanUngureanu
Copy link
Contributor

@BogdanUngureanu BogdanUngureanu commented Jul 29, 2025

Replace the Calypso link to Stats with the WP-Admin equivalent.

Beside the actual change, the menu definitions have been also removed from nav-unification.

Fixes DOTCOM-14031

Proposed changes:

  • Replace the Stats Calypso link in the admin menu with the WP-Admin link.
  • Remove the stats definitions from Nav-Unification

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply this PR on your Sandbox and on your Atomic site
  • Notice that Stats menu item now points to the WP-Admin page instead of Calypso
  • On Atomic sites, also disable the "Stats" module in Jetpack > Settings > Modules > Stats
  • Notice that the item no longer appears in the admin menu.

Copy link
Contributor

github-actions bot commented Jul 29, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/stats-link-to-wp-admin branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/stats-link-to-wp-admin
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/stats-link-to-wp-admin

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jul 29, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 29, 2025
Copy link

jp-launch-control bot commented Jul 29, 2025

Code Coverage Summary

Coverage changed in 4 files.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-menu/wpcom-admin-menu.php 0/356 (0.00%) 0.00% 5 💔
projects/packages/masterbar/src/admin-menu/class-admin-menu.php 161/210 (76.67%) -0.22% 0 💚
projects/packages/masterbar/src/admin-menu/class-wpcom-admin-menu.php 41/141 (29.08%) 1.56% -8 💚
projects/packages/masterbar/src/admin-menu/class-atomic-admin-menu.php 49/124 (39.52%) 2.95% -10 💚

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@BogdanUngureanu BogdanUngureanu added I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jul 30, 2025
@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [mu wpcom Feature] Wpcom Admin Menu [Package] Jetpack mu wpcom WordPress.com Features [Package] Masterbar [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Team Review Obsolete. Use Needs Review instead. [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant