Newsletter Categories: add helper class #44537

arcangelini · 2025-07-30T03:10:10Z

Proposed changes:

Add new helper class for getting and setting newsletter category option
Use helper in WPCOM_JSON_API_Site_Settings_Endpoint and Jetpack_Core_API_Data
Adds unit tests to cover new class and make sure all areas are *nsync

The original issue was related to the wpcom_newsletter_categories option being stored in one format [{term_id: 123}, {term_id: 456}] but being returned in 2 different versions. The API endpoint was returning [123, 456] but the redux store for Jetpack was being populated with the raw version. This was causing discrepancies in how we display and save the data.

To prevent code duplication and allow for cleaner testing I made a helper class.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

No

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Add this change to an Atomic site.

Go to YOUR_ATOMIC_SITE.com/wp-admin/admin.php?page=jetpack#newsletter
Toggle the newsletter categories and save
Refresh the page and make sure the changes persist
For fun — you can open the console on this page and view window.Initial_State.settings.wpcom_newsletter_categories to make sure you are getting the proper formatting.

Add this change to an Atomic site.

Go to https://wordpress.com/settings/newsletter/YOUR_ATOMIC_SITE.com
Toggle the newsletter categories and save
Refresh the page and make sure the changes persist

github-actions · 2025-07-30T03:11:01Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the arcanagelinis/newsletter-fix-v2 branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack arcanagelinis/newsletter-fix-v2

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-07-30T03:11:16Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: August 5, 2025
- Code freeze: August 4, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-07-30T03:19:04Z

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/_inc/client/newsletter/newsletter-categories.jsx	0/30 (0.00%)	0.00%	1 ❤️‍🩹
projects/plugins/jetpack/_inc/lib/core-api/class.jetpack-core-api-module-endpoints.php	166/877 (18.93%)	0.63%	-17 💚
projects/plugins/jetpack/json-endpoints/class.wpcom-json-api-site-settings-endpoint.php	337/781 (43.15%)	1.08%	-27 💚

1 file is newly checked for coverage.

File	Coverage
projects/plugins/jetpack/_inc/lib/class-jetpack-newsletter-category-helper.php	27/28 (96.43%) 💚

Full summary · PHP report · JS report

arcangelini · 2025-07-30T04:55:57Z

projects/plugins/jetpack/_inc/client/newsletter/newsletter-categories.jsx

@@ -54,7 +54,10 @@ function NewsletterCategories( props ) {
 		dispatch,
 	} = props;

-	const checkedCategoriesIds = newsletterCategories.map( mapCategoriesIds );


This was causing an error because it is possible for newsletterCategories to be undefined in the beginning

allilevine

Thanks for aligning these! 🙌 I can update Atomic categories from both Calypso and Jetpack settings without errors.

I still can't enable/disable categories overall from Calypso for an Atomic site. Is that a separate fix?

projects/plugins/jetpack/_inc/lib/core-api/class.jetpack-core-api-module-endpoints.php

arcangelini · 2025-07-30T20:08:55Z

I still can't enable/disable categories overall from Calypso for an Atomic site. Is that a separate fix?

@allilevine thanks for pointing that out. I did not know that this was an issue as well I thought only the category picker was broken.

allilevine

All Calypso category settings changes are working for me. ✅

arcangelini added 3 commits July 29, 2025 15:44

Newsletter Categories: add helper class

7ba9793

Use helper class across Jetpack

db9234d

changelog

58730e3

arcangelini requested a review from a team July 30, 2025 03:10

arcangelini self-assigned this Jul 30, 2025

arcangelini added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. labels Jul 30, 2025

github-actions bot added [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Jul 30, 2025

Add tests

0b36a36

github-actions bot added the [Tests] Includes Tests label Jul 30, 2025

arcangelini and others added 5 commits July 29, 2025 23:29

Merge branch 'trunk' into arcanagelinis/newsletter-fix-v2

27d0ab7

fix stuff

a69489b

remove unneccessary test

aa8187a

remove unneccessary test

bbc7e9b

fix race condition

0279a43

github-actions bot added the Admin Page React-powered dashboard under the Jetpack menu label Jul 30, 2025

arcangelini commented Jul 30, 2025

View reviewed changes

Merge branch 'trunk' into arcanagelinis/newsletter-fix-v2

86f03ad

allilevine reviewed Jul 30, 2025

View reviewed changes

projects/plugins/jetpack/_inc/lib/core-api/class.jetpack-core-api-module-endpoints.php Show resolved Hide resolved

arcangelini and others added 2 commits July 30, 2025 15:24

Merge branch 'trunk' into arcanagelinis/newsletter-fix-v2

1f58197

Fix toggling

637c9bc

allilevine approved these changes Jul 30, 2025

View reviewed changes

arcangelini merged commit 8e6e8a9 into trunk Jul 30, 2025
73 of 76 checks passed

arcangelini deleted the arcanagelinis/newsletter-fix-v2 branch July 30, 2025 21:22

github-actions bot added this to the jetpack/14.9 milestone Jul 30, 2025

github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Newsletter Categories: add helper class #44537

Newsletter Categories: add helper class #44537

Uh oh!

arcangelini commented Jul 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Jul 30, 2025 •

edited

Loading

Uh oh!

arcangelini Jul 30, 2025

Uh oh!

allilevine left a comment

Uh oh!

Uh oh!

arcangelini commented Jul 30, 2025

Uh oh!

allilevine left a comment

Uh oh!

Uh oh!

Uh oh!

Newsletter Categories: add helper class #44537

Newsletter Categories: add helper class #44537

Uh oh!

Conversation

arcangelini commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Add this change to an Atomic site.

Add this change to an Atomic site.

Uh oh!

github-actions bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

arcangelini Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

allilevine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arcangelini commented Jul 30, 2025

Uh oh!

allilevine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

arcangelini commented Jul 30, 2025 •

edited

Loading

github-actions bot commented Jul 30, 2025 •

edited

Loading

github-actions bot commented Jul 30, 2025 •

edited

Loading

jp-launch-control bot commented Jul 30, 2025 •

edited

Loading