Skip to content

Forms: Fix checkbox styling with filter invert and correct border color #46150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CGastrell wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Forms: Fix checkbox styling with filter invert and correct border color #46150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbe6021
split border rule declaration. Use text-color var for it
CGastrell Dec 1, 2025
5ba98a3
use filter invert on checked checkbox
CGastrell Dec 1, 2025
7f2ff07
changelog
CGastrell Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/forms/changelog/fix-form-checkbox-style-solution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Fix checkbox styling in forms by using filter invert and correct border color variable
5 changes: 3 additions & 2 deletions projects/packages/forms/src/contact-form/css/grunion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,7 +1052,7 @@ on production builds, the attributes are being reordered, causing side-effects
.contact-form .is-style-list input.consent:checked,
.contact-form .is-style-list input.checkbox:checked,
.contact-form .grunion-field-wrap:not(.is-style-plain) input.checkbox-multiple:checked {
background-color: currentColor;
filter: invert(1);

}

Expand All @@ -1071,7 +1071,8 @@ on production builds, the attributes are being reordered, causing side-effects
transition: opacity 0.1s ease-in-out, scale 0.15s ease-in-out;

font-size: inherit;
border: solid var(--jetpack--contact-form--inverted-text-color, var(--jetpack--contact-form--input-background));
border-style: solid;
border-color: var(--jetpack--contact-form--text-color);
border-width: 0 2px 2px 0;
transform: translate(-50%, -60%) rotate(40deg);
top: 0;
Expand Down
Loading