-
Notifications
You must be signed in to change notification settings - Fork 841
Forms: Soften invalid form language #46210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Updates the error text for invalid forms from "Please fill out the form correctly" to "Please complete all required fields to continue".
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
| 'is_required' => __( 'This field is required.', 'jetpack-forms' ), | ||
| 'invalid_form_empty' => __( 'The form you are trying to submit is empty.', 'jetpack-forms' ), | ||
| 'invalid_form' => __( 'Please fill out the form correctly.', 'jetpack-forms' ), | ||
| 'invalid_form' => __( 'Please complete all required fields to continue.', 'jetpack-forms' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to split this error into two; one for multiple required fields, missing and another for invalid content like invalid email.
You might have no required fields at all in the form, and only issue is that email was filled incorrect, for example.
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: