Optimize test efficiency in schema.test.js #15747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize test efficiency: avoid redundant validateSync() calls
vkarpov15
reviewed
Nov 17, 2025
vkarpov15
reviewed
Nov 17, 2025
Collaborator
vkarpov15
left a comment
vkarpov15
left a comment
There was a problem hiding this comment.
I appreciate the contribution, but even without the syntax error this PR isn't helpful. Improves performance in tests by the cost of validating a document with 1 path, which is trivial; debatable impact on readability; net negative on consistency because we try to avoid intermediate variables in tests. I'm going to close this one, thanks for the PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the test "booleans cause cast error for date (gh-3935)" in
test/schema.test.jsby removing redundant calls totest.validateSync().Previously, the test invoked
validateSync()twice within its assertions, which was unnecessary.The updated approach stores the result in
validationResultand reuses it, improving test efficiency.Examples
This is a test-only optimization and does not introduce new features or modify runtime behavior.
No additional examples are required, and the existing test continues to pass with the updated implementation.