Skip to content

fix(acap-build): Archive and extract files instead of cp #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

fix(acap-build): Archive and extract files instead of cp #205

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3d4b74f
fix(acap-build): Use '--update=none' instead of '-n'
Jul 23, 2025
bae6d61
Revert "fix(acap-build): Use '--update=none' instead of '-n'"
Jul 24, 2025
494dc33
Archive and unpack files instead of copying
Jul 24, 2025
4b95df2
Write manifest like before
Jul 24, 2025
b7bdd3b
Add archived files to self.files
Jul 24, 2025
c03fa10
set_overwrite(false) like cp -n
Jul 24, 2025
66dcf5f
Remove set_preserve_permissions
Jul 24, 2025
e999bcd
Merge remote-tracking branch 'upstream/main' into cp-arg
Jul 28, 2025
a488b54
Respect preserve_permissions
Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/acap-build/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ fn copy<P: AsRef<Path>, Q: AsRef<Path>>(
cp.arg("--preserve=mode");
}

cp.arg("-dn").arg(src.as_os_str()).arg(dst.as_os_str());
cp.arg("-d").arg("--update=none").arg(src.as_os_str()).arg(dst.as_os_str());

if !cp.status()?.success() {
bail!("Failed to copy symlink: {}", src.display());
Expand Down
Loading