Skip to content

Conversation

smcvb
Copy link
Member

@smcvb smcvb commented Feb 14, 2025

Update Axon Framework to 4.11.0.

Besides the version increment, this PR also makes the TracingCommandGateway and TracingQueryGateway beans @Lazy.
Made this adjustment, as with the version increment the Spring Boot auto-configuration started to complain that the gateways couldn't be constructed because their respective buses weren't ready yet.
To be frank, it is unclear to me why this happens now. If anything, I would write it off as a classpath change with newer Spring (Boot) versions that are now being used.

Update Axon Framework to 4.11.0

#dependency-upgrade/af-4.11.0
@smcvb smcvb added this to the Release 4.11.0 milestone Feb 14, 2025
@smcvb smcvb requested a review from a team February 14, 2025 10:57
@smcvb smcvb self-assigned this Feb 14, 2025
@smcvb smcvb requested review from CodeDrivenMitch, MateuszNaKodach and abuijze and removed request for a team February 14, 2025 10:57
Fix auto-config ordering issues. Made the tracing CommandGateway and
QueryGateway lazy. I anticipate this is now necessary because of a newer
 Spring Boot versions that's being used.

#dependency-upgrade/af-4.11.0
Copy link

Copy link

@MateuszNaKodach MateuszNaKodach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your judgement with the fix!

@smcvb smcvb merged commit 278a09f into master Feb 14, 2025
8 checks passed
@smcvb smcvb deleted the dependency-upgrade/af-4.11.0 branch February 14, 2025 12:42
@cyrilcolinet
Copy link

@smcvb The change to lazy initialization also introduces a new circular dependency when injecting CommandGateway, and tracing enabled.

After some investigation, I found that excluding InterceptorAutoConfiguration from the auto-configurations (added in AxonFramework/AxonFramework#3203) resolves the circular dependency.

Maybe this can help you

@MateuszNaKodach
Copy link

@smcvb The change to lazy initialization also introduces a new circular dependency when injecting CommandGateway, and tracing enabled.

After some investigation, I found that excluding InterceptorAutoConfiguration from the auto-configurations (added in AxonFramework/AxonFramework#3203) resolves the circular dependency.

Maybe this can help you

Thanks @cyrilcolinet!
Excluding InterceptorAutoConfiguration it's indeed a temporary workaround for that.

We already found the bug and fixed it here:
AxonFramework/AxonFramework#3290

We just need to release Axon Framework 4.11.1, and update the version in the extension.

@cyrilcolinet
Copy link

Oh ure fast, I'll check the fix by curiosity.
Thanks !

@smcvb
Copy link
Member Author

smcvb commented Feb 21, 2025

@cyrilcolinet, I came here to nudge you that 4.11.1 of Axon Framework was just released. Combining that release with the latest of the tracing extension should solve the circular dependency issue you were seeing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants