Skip to content

Remove unused principalId parameter from Bicep templates #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove unused principalId parameter from Bicep templates #19

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
429475e
Initial plan for issue
Copilot May 21, 2025
abde02e
Remove principalId parameter from bicep files
Copilot May 21, 2025
3bdb144
Revert principalId parameter removal from main.parameters.json
Copilot May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions infra/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ param location string
param mcpTodoServerAppExists bool
param mcpTodoClientAppExists bool

@description('Id of the user or app to assign application roles')
param principalId string

Comment on lines -15 to -17
Copy link

@vhvb1989 vhvb1989 May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct @copilot . You need to remove the parameter only from the resources.bicep module. You need to keep this parameter from the main.bicep file

Copy link

@vhvb1989 vhvb1989 May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot you are missing these comments

@description('Whether to use the built-in login feature for the application or not')
param useLogin bool = true

Expand Down Expand Up @@ -48,7 +45,6 @@ module resources 'resources.bicep' = {
environmentName: environmentName
location: location
tags: tags
principalId: principalId
mcpTodoServerAppExists: mcpTodoServerAppExists
mcpTodoClientAppExists: mcpTodoClientAppExists
useLogin: useLogin
Expand Down
3 changes: 0 additions & 3 deletions infra/main.parameters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@
"mcpTodoServerAppExists": {
"value": "${SERVICE_MCPTODO_SERVERAPP_RESOURCE_EXISTS=false}"
},
"principalId": {
"value": "${AZURE_PRINCIPAL_ID}"
},
Copy link

@vhvb1989 vhvb1989 May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove this mapping from here

Copy link
Collaborator

@achandmsft achandmsft May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can you please not remove the principal id from this main.parameters.json file and resend the PR for review?

"useLogin": {
"value": "${USE_LOGIN=true}"
},
Expand Down
3 changes: 0 additions & 3 deletions infra/resources.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ param tags object = {}
param mcpTodoClientAppExists bool
param mcpTodoServerAppExists bool

@description('Id of the user or app to assign application roles')
param principalId string

@description('Whether to use the built-in login feature for the application or not')
param useLogin bool = true

Expand Down