chore: update PR template #7569
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronmeissner
requested review from
AbelHu,
Devinwong,
awesomenix,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
awesomenix
reviewed
Dec 17, 2025
|
|
||
| **Requirements**: | ||
|
|
||
| - [ ] uses [conventional commit messages](https://www.conventionalcommits.org/) |
Contributor
There was a problem hiding this comment.
I thought there is a PR lint check which forces you to have this in PR title (which is mostly derived from commit message)
awesomenix
approved these changes
Dec 17, 2025
djsly
reviewed
Dec 19, 2025
|
|
||
| **What this PR does / why we need it**: | ||
|
|
||
| **Which issue(s) this PR fixes**: |
Collaborator
There was a problem hiding this comment.
what shioudl we be putting in here ? we don't really have github issue...
djsly
reviewed
Dec 19, 2025
| - [ ] includes documentation | ||
| - [ ] adds unit tests | ||
| - [ ] tested upgrade from previous version | ||
| - [ ] commits are GPG signed and Github marks them as verified |
Collaborator
There was a problem hiding this comment.
I would leave this here with a URL to the readme we have in the repo ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: