feat(cloud-provider-azure): use Dalec for >= v1.32.11 #7591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liunardy <54991798+Liunardy@users.noreply.github.com>
github-actions
bot
added
the
components
5 tasks
Contributor
Changes cached containers or packages on windows VHDsPlease get a Windows SIG member to approve. The following dif file shows any additions or deletions from what will be cached on windows VHDs organised by VHD type.
diff --git a/vhd_files/2019-containerd.txt b/vhd_files/2019-containerd.txt
index 80d24f0..9cd3775 100644
--- a/vhd_files/2019-containerd.txt
+++ b/vhd_files/2019-containerd.txt
@@ -3,0 +4,3 @@ c:\akse-cache\aks-secure-tls-bootstrap-client\: https://github.com/Azure/aks-sec
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.32.11/windows/amd64/azure-acr-credential-provider_1.32.11-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.33.6/windows/amd64/azure-acr-credential-provider_1.33.6-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.34.3/windows/amd64/azure-acr-credential-provider_1.34.3-1_amd64.zip
@@ -78 +81,3 @@ mcr.microsoft.com/oss/v2/kubernetes-csi/secrets-store/driver:v1.5.4
-mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.32.11-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.33.6-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc-1
diff --git a/vhd_files/2022-containerd-gen2.txt b/vhd_files/2022-containerd-gen2.txt
index 6bc4a5c..2f0a227 100644
--- a/vhd_files/2022-containerd-gen2.txt
+++ b/vhd_files/2022-containerd-gen2.txt
@@ -3,0 +4,3 @@ c:\akse-cache\aks-secure-tls-bootstrap-client\: https://github.com/Azure/aks-sec
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.32.11/windows/amd64/azure-acr-credential-provider_1.32.11-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.33.6/windows/amd64/azure-acr-credential-provider_1.33.6-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.34.3/windows/amd64/azure-acr-credential-provider_1.34.3-1_amd64.zip
@@ -128 +131,3 @@ mcr.microsoft.com/oss/v2/kubernetes-csi/secrets-store/driver:v1.5.4
-mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.32.11-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.33.6-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc-1
diff --git a/vhd_files/2022-containerd.txt b/vhd_files/2022-containerd.txt
index a8590c3..0624d0b 100644
--- a/vhd_files/2022-containerd.txt
+++ b/vhd_files/2022-containerd.txt
@@ -3,0 +4,3 @@ c:\akse-cache\aks-secure-tls-bootstrap-client\: https://github.com/Azure/aks-sec
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.32.11/windows/amd64/azure-acr-credential-provider_1.32.11-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.33.6/windows/amd64/azure-acr-credential-provider_1.33.6-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.34.3/windows/amd64/azure-acr-credential-provider_1.34.3-1_amd64.zip
@@ -128 +131,3 @@ mcr.microsoft.com/oss/v2/kubernetes-csi/secrets-store/driver:v1.5.4
-mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.32.11-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.33.6-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc-1
diff --git a/vhd_files/2025-gen2.txt b/vhd_files/2025-gen2.txt
index e27690e..3374953 100644
--- a/vhd_files/2025-gen2.txt
+++ b/vhd_files/2025-gen2.txt
@@ -3,0 +4,3 @@ c:\akse-cache\aks-secure-tls-bootstrap-client\: https://github.com/Azure/aks-sec
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.32.11/windows/amd64/azure-acr-credential-provider_1.32.11-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.33.6/windows/amd64/azure-acr-credential-provider_1.33.6-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.34.3/windows/amd64/azure-acr-credential-provider_1.34.3-1_amd64.zip
@@ -58 +61,3 @@ mcr.microsoft.com/oss/v2/kubernetes-csi/secrets-store/driver:v1.5.4
-mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.32.11-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.33.6-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc-1
diff --git a/vhd_files/2025.txt b/vhd_files/2025.txt
index fec8e92..677b345 100644
--- a/vhd_files/2025.txt
+++ b/vhd_files/2025.txt
@@ -3,0 +4,3 @@ c:\akse-cache\aks-secure-tls-bootstrap-client\: https://github.com/Azure/aks-sec
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.32.11/windows/amd64/azure-acr-credential-provider_1.32.11-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.33.6/windows/amd64/azure-acr-credential-provider_1.33.6-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.34.3/windows/amd64/azure-acr-credential-provider_1.34.3-1_amd64.zip
@@ -58 +61,3 @@ mcr.microsoft.com/oss/v2/kubernetes-csi/secrets-store/driver:v1.5.4
-mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.32.11-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.33.6-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc-1
diff --git a/vhd_files/23H2-gen2.txt b/vhd_files/23H2-gen2.txt
index 2440903..13d838a 100644
--- a/vhd_files/23H2-gen2.txt
+++ b/vhd_files/23H2-gen2.txt
@@ -3,0 +4,3 @@ c:\akse-cache\aks-secure-tls-bootstrap-client\: https://github.com/Azure/aks-sec
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.32.11/windows/amd64/azure-acr-credential-provider_1.32.11-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.33.6/windows/amd64/azure-acr-credential-provider_1.33.6-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.34.3/windows/amd64/azure-acr-credential-provider_1.34.3-1_amd64.zip
@@ -78 +81,3 @@ mcr.microsoft.com/oss/v2/kubernetes-csi/secrets-store/driver:v1.5.4
-mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.32.11-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.33.6-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc-1
diff --git a/vhd_files/23H2.txt b/vhd_files/23H2.txt
index 8664ed3..02092ca 100644
--- a/vhd_files/23H2.txt
+++ b/vhd_files/23H2.txt
@@ -3,0 +4,3 @@ c:\akse-cache\aks-secure-tls-bootstrap-client\: https://github.com/Azure/aks-sec
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.32.11/windows/amd64/azure-acr-credential-provider_1.32.11-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.33.6/windows/amd64/azure-acr-credential-provider_1.33.6-1_amd64.zip
+c:\akse-cache\azure-acr-credential-provider\: https://packages.aks.azure.com/dalec-packages/azure-acr-credential-provider/1.34.3/windows/amd64/azure-acr-credential-provider_1.34.3-1_amd64.zip
@@ -78 +81,3 @@ mcr.microsoft.com/oss/v2/kubernetes-csi/secrets-store/driver:v1.5.4
-mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.32.11-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.33.6-windows-hpc-1
+mcr.microsoft.com/oss/v2/kubernetes/azure-cloud-node-manager:v1.34.3-windows-hpc-1 |
Devinwong
reviewed
Dec 23, 2025
| }, | ||
| { | ||
| "renovateTag": "registry=https://mcr.microsoft.com, name=oss/v2/kubernetes/azure-cloud-node-manager", | ||
| "latestVersion": "v1.33.6-1" |
Collaborator
There was a problem hiding this comment.
Should we remove the v1.33.6 (etc.) from oss/kubernetes/azure-cloud-node-manager above if we are caching the v2 (Dalec) ones? We are very careful about caching new versions because the VHD size often reach the disk size limit. Could you please make sure we only cache the necessary ones?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Migrate cloud-provider-azure >= v1.32.11 to use Dalec.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: