add AKS Swiftv2 Manifold E2E in ACN pipeline #4128
Conversation
| # AKS Swiftv2 Singularity E2E tests | ||
| - template: multitenancy/swiftv2-singularity-e2e.stages.yaml | ||
| parameters: | ||
| dependsOn: manifests |
There was a problem hiding this comment.
This needs to be added to ACN PR pipeline.yaml as well or it will get missed before a Tag is created... We do not want to create multiple tags because of a CI/CD miss.
There was a problem hiding this comment.
We currently don't have the hardware to support multiple runs as ACN PR pipeline is used.
sharifnasser
force-pushed
the
sharifna/pipeline/singularity
branch
from
ac53d7a to
4c05682
Compare
sharifnasser
force-pushed
the
sharifna/pipeline/singularity
branch
from
0280e70 to
a452830
Compare
sharifnasser
changed the title
| templateParameters: 'useAcnPublic: true, cnscniversion: $(TAG), cnscniversionwindows: $(TAG), cnscniImagePrefix: $(IMAGE_REPO_PATH)/' | ||
| useSameBranch: false | ||
| queueBuildForUserThatTriggeredBuild: true | ||
| branchToUse: 'refs/heads/sharifna/runner/release-gate' |
There was a problem hiding this comment.
Need to change this to master branch once Runners pipeline changes are merged.
sharifnasser
force-pushed
the
sharifna/pipeline/singularity
branch
from
64db33a to
ce3da3d
Compare
sharifnasser
force-pushed
the
sharifna/pipeline/singularity
branch
from
ce3da3d to
4b8616c
Compare
| ${{ if eq(parameters.dependsOn, 'publish') }}: | ||
| IMAGE_REPO_PATH_REF: 'azure-' | ||
| ${{ else }}: | ||
| IMAGE_REPO_PATH_REF: $(IMAGE_REPO_PATH) |
There was a problem hiding this comment.
Can you explain the flow on how this works?
There was a problem hiding this comment.
This template is shared by PR Pipeline (pipeline.yaml) and the ACN Test Unofficial pipeline (run-pipeline.yaml). I'm doing this so I can pass the right prefix to Singularity Runners when pulling CNS/CNI images. Example: acnpublic.azurecr.io/azure-cns:vX.x.x-xx
ACN Test Unofficial publishes to IMAGE_REPO_PATH artifact/dd590928-4e04-48cb-9d3d-ee06c5f0e17f/buddy which is used as: acnpublic.azurecr.io/ artifact/dd590928-4e04-48cb-9d3d-ee06c5f0e17f/buddy/ cns:vX.x.x-xx
PR Pipeline has a null value for IMAGE_REPO_PATH so it's replaced by: acnpublic.azurecr.io/ azure- cns:vX.x.x-xx
In the case of including it in the Official Build pipeline, it publishes to IMAGE_REPO_PATH 'artifact/dd590928-4e04-48cb-9d3d-ee06c5f0e17f/official', which would be used as:
acnpublic.azurecr.io/ artifact/dd590928-4e04-48cb-9d3d-ee06c5f0e17f/official/ cns:vX.x.x-xx
Bold section is what is used as the cnscniImagePrefix in Singularity Runners
Reason for Change:
This PR adds AKS Swiftv2 Manifold E2E tests to the ACN pipeline to ensure that newer CNS/CNI versions pass these scenarios testing (BYON Accelnet and IB on Windows and Linux) before being released.
Issue Fixed:
Requirements:
Notes: