Fix: AZD should not delete user-provided packages when using --from-package #5445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: vhvb1989 <24213737+vhvb1989@users.noreply.github.com>
…ackage - Add IsTemporary field to ServicePackageResult to track whether packages should be cleaned up - Update deploy command to mark user-provided packages (--from-package) as non-temporary - Update AppService and FunctionApp targets to only delete packages when IsTemporary=true - Update framework services that create temp directories to mark packages as temporary - Add comprehensive tests to verify package cleanup behavior Co-authored-by: vhvb1989 <24213737+vhvb1989@users.noreply.github.com>
Copilot
AI
changed the title
azd deploy --from-package
Copilot finished work on behalf of
vhvb1989
July 8, 2025 00:07
|
/azp run azure-dev - cli |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JeffreyCA
requested review from
wbreza,
hemarina,
weikanglim,
JeffreyCA,
tg-msft and
rajeshkamal5050
as code owners
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
weikanglim
reviewed
Jul 8, 2025
Based on feedback from @weikanglim, implement cleaner separation of concerns: - Remove IsTemporary field from ServicePackageResult - Remove package cleanup from AppService/FunctionApp Deploy methods - Handle cleanup in deploy.go command where package creation context is known - Only clean up packages created by Package() method, preserve user-provided packages - Add test to verify correct cleanup behavior This approach is cleaner because the deploy command, which knows whether it created a temporary package or the user provided one via --from-package, handles cleanup instead of passing metadata through the ServicePackageResult. Co-authored-by: weikanglim <2322434+weikanglim@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
weikanglim
July 9, 2025 00:01
vhvb1989
reviewed
Jul 9, 2025
Co-authored-by: vhvb1989 <24213737+vhvb1989@users.noreply.github.com>
Copilot finished work on behalf of
vhvb1989
July 9, 2025 16:50
vhvb1989
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AZD was unconditionally deleting packages after deployment, including user-provided packages when using the
--from-packageflag. This broke user expectations as they don't expect their own files to be deleted.The issue was in
service_target_appservice.goline 84 andservice_target_functionapp.goline 86 where:This line always deleted the package, regardless of whether AZD created it or the user provided it.
Solution
Added an
IsTemporaryfield toServicePackageResultto track whether packages should be cleaned up after deployment:--from-package): marked asIsTemporary: falseIsTemporary: trueChanges Made
IsTemporary boolfield--from-packageis used, packages are marked as non-temporaryIsTemporaryis trueExample
Before this fix:
After this fix:
While AZD-created temporary packages are still properly cleaned up to avoid disk space issues.
Fixes #5444.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.msdownloads.bicep.azure.com/tmp/go-build2309065558/b906/bicep.test -test.testlogfile=/tmp/go-build2309065558/b906/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.short=true(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.