[Az.SignalR] Update generation tool version: autorest.powershell v3->v4 #28809
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
|
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Azure SignalR PowerShell module with API changes and improved user experience. The changes include adding three new Update cmdlets (Update-AzWebPubSubHub, Update-AzWebPubSubCustomDomain, Update-AzWebPubSubCustomCertificate) and updating existing cmdlets to use a new parameter format for managed identity configuration.
Key changes:
- Added three new Update cmdlets for WebPubSub resources (Hub, CustomDomain, CustomCertificate)
- Changed identity parameter from
-IdentityTypeto-EnableSystemAssignedIdentityand-UserAssignedIdentityin New/Update cmdlets - Updated help documentation for all affected cmdlets
- Added test coverage for new cmdlets
- Updated ChangeLog.md with breaking changes notice
Reviewed Changes
Copilot reviewed 127 out of 132 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/SignalR/SignalR/ChangeLog.md | Added changelog entry noting improved UX and breaking changes |
| src/SignalR/SignalR/help/*.md | Added help documentation for new Update cmdlets and updated existing cmdlet documentation |
| src/SignalR/SignalR/Az.SignalR.psd1 | Updated module manifest to export new cmdlets and updated metadata |
| src/SignalR/SignalR.Autorest/test/*.Tests.ps1 | Added/updated test files for new and modified cmdlets |
| src/SignalR/SignalR.Autorest/examples/*.md | Added/updated example documentation |
| src/SignalR/SignalR.sln | Updated solution file with new project configurations |
| - Additional information about change #1 | ||
| --> | ||
| ## Upcoming Release | ||
| * Improved user experience and consistency. This may introduce breaking changes. Please refer to [here](https://go.microsoft.com/fwlink/?linkid=2340249). |
There was a problem hiding this comment.
The changelog entry is too vague for users. According to coding guidelines, changelog entries should be written from the user's perspective with specific details. This should explain what breaking changes were made (e.g., parameter name changes from -IdentityType to -EnableSystemAssignedIdentity and -UserAssignedIdentity).
| { | ||
| # Clean resources you create for testing | ||
| Remove-AzResourceGroup -Name $env.ResourceGroupName | ||
| # Remove-AzResourceGroup -Name $env.ResourceGroupName |
There was a problem hiding this comment.
The cleanup function has been commented out, which may leave test resources behind. This should be uncommented or documented why it's disabled. Test cleanup is important to avoid accumulating resources and costs.
Description
In 2026-05 release.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.