Skip to content

Conversation

@Ptnan7
Copy link
Member

@Ptnan7 Ptnan7 commented Nov 7, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings November 7, 2025 23:51
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the FrontDoor module to AutoRest PowerShell V4 and ensures PowerShell 5.1 compatibility by replacing ternary operators with if-else blocks. Key changes include:

  • Replaced PowerShell 7.0+ ternary operators with PowerShell 5.1-compatible if-else blocks in routing rule and rules engine cmdlets
  • Updated help documentation URL casing
  • Regenerated AutoRest artifacts (GUIDs, generate_Id)

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/FrontDoor/FrontDoor/help/New-AzFrontDoorBackendPoolsSettingObject.md Updated online help URL with correct module name casing
src/FrontDoor/FrontDoor/Az.FrontDoor.psd1 Updated generated date timestamp
src/FrontDoor/FrontDoor.sln Regenerated project GUIDs for AutoRest project reference
src/FrontDoor/FrontDoor.Autorest/generate-info.json Updated AutoRest generation identifier
src/FrontDoor/FrontDoor.Autorest/docs/Az.FrontDoor.md Updated module GUID after regeneration
src/FrontDoor/FrontDoor.Autorest/custom/New-AzFrontDoorRulesEngineActionObject.ps1 Replaced ternary operators with if-else blocks for PowerShell 5.1 compatibility
src/FrontDoor/FrontDoor.Autorest/custom/New-AzFrontDoorRoutingRuleObject.ps1 Replaced ternary operators with if-else blocks for PowerShell 5.1 compatibility

external help file: Az.FrontDoor-help.xml
Module Name: Az.FrontDoor
online version: https://learn.microsoft.com/powershell/module/az.frontdoor/new-azfrontdoorbackendpoolssettingobject
online version: https://learn.microsoft.com/powershell/module/Az.FrontDoor/new-azfrontdoorbackendpoolssettingsobject
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL contains a typo in the cmdlet name. The URL ends with "new-azfrontdoorbackendpoolssettingsobject" (with double 's' in "settingsobject"), but the correct cmdlet name is "New-AzFrontDoorBackendPoolsSettingObject" which should be lowercased to "new-azfrontdoorbackendpoolssettingobject" in the URL. There should be only one 's' between "setting" and "object".

Suggested change
online version: https://learn.microsoft.com/powershell/module/Az.FrontDoor/new-azfrontdoorbackendpoolssettingsobject
online version: https://learn.microsoft.com/powershell/module/Az.FrontDoor/new-azfrontdoorbackendpoolssettingobject

Copilot uses AI. Check for mistakes.
@isra-fel
Copy link
Member

isra-fel commented Nov 8, 2025

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants