Skip to content

Conversation

kashish2508
Copy link
Member

Packages impacted by this PR

@azure/playwright

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@Copilot Copilot AI review requested due to automatic review settings July 24, 2025 16:20
@kashish2508 kashish2508 requested review from bterlson and a team as code owners July 24, 2025 16:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the runId parameter from the service configuration options for the Azure Playwright service, making run ID generation fully automatic and internal. The change simplifies the API by eliminating user control over run IDs while ensuring they are still generated and managed internally.

Key changes:

  • Removed runId from PlaywrightServiceAdditionalOptions type and public API
  • Modified PlaywrightServiceConfig to automatically generate run IDs via getter instead of storing them as instance properties
  • Updated all tests to mock the getAndSetRunId utility function instead of passing explicit run IDs

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/common/types.ts Removed runId property from PlaywrightServiceAdditionalOptions type
src/common/playwrightServiceConfig.ts Converted runId from instance property to getter that automatically generates IDs
src/common/environmentVariables.ts Fixed environment variable reference to use constant instead of hardcoded string
test/core/playwrightService.spec.ts Updated tests to mock getAndSetRunId and removed explicit runId parameters
test/common/playwrightServiceConfig.spec.ts Rewrote tests to verify automatic run ID generation behavior
samples/v1/typescript/customising-service-parameters/playwright.service.config.ts Removed runId from sample configuration
review/playwright-node.api.md Updated API documentation to reflect removal of runId property
Comments suppressed due to low confidence (2)

sdk/loadtesting/playwright/test/core/playwrightService.spec.ts:253

  • This line removes the runId parameter from the service config call, but the removal appears incomplete as the line is marked for deletion but may still be present. Ensure the parameter is completely removed from the function call.
      os: ServiceOS.WINDOWS,

sdk/loadtesting/playwright/test/core/playwrightService.spec.ts:431

  • Similar to the previous issue, this runId parameter appears to be marked for removal but may still be present in the function call. Verify that all runId parameters are completely removed from test function calls.
    await getConnectOptions({

Copy link

github-actions bot commented Jul 24, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/playwright

@Sid200026 Sid200026 reopened this Jul 25, 2025
@kashish2508 kashish2508 changed the title feat(loadtestservice): removed runID from service config [WIP]feat(loadtestservice): removed runID from service config Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants