Skip to content

[AutoRelease] t2-sql-2025-07-29-33255(can only be merged by SDK owner) #42251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

azure-sdk
Copy link
Collaborator

https://github.com/Azure/sdk-release-request/issues/6435
Recording test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1034
BuildTargetingString
azure-mgmt-sql
Skip.CreateApiReview

@Copilot Copilot AI review requested due to automatic review settings July 29, 2025 03:23
@azure-sdk
Copy link
Collaborator Author

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR is an auto-generated release update for the Azure SQL Management SDK (azure-mgmt-sql) targeting version 2025-07-29-33255. The changes modernize the async operations code structure by updating import patterns, removing legacy Python version compatibility code, and consolidating hardcoded API version strings.

  • Updates import structure to use direct imports instead of conditional imports based on Python version
  • Adds type annotations for better type safety in operations classes
  • Standardizes API version handling by replacing dynamic version lookup with hardcoded preview versions
  • Simplifies pagination logic by removing complex URL parsing for next links

@@ -169,7 +77,7 @@ async def get(
:param database_name: The name of the managed database for which the security alert policy is
defined. Required.
:type database_name: str
:param security_alert_policy_name: The name of the security alert policy. "default" Required.
:param security_alert_policy_name: The name of the security alert policy. "Default" Required.
Copy link
Preview

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring has inconsistent capitalization. It shows "Default" instead of "default". Based on the pattern in other files that show "default", this should be "default" (lowercase) for consistency.

Suggested change
:param security_alert_policy_name: The name of the security alert policy. "Default" Required.
:param security_alert_policy_name: The name of the security alert policy. "default" Required.

Copilot uses AI. Check for mistakes.

@@ -242,7 +149,7 @@ async def create_or_update(
:param database_name: The name of the managed database for which the security alert policy is
defined. Required.
:type database_name: str
:param security_alert_policy_name: The name of the security alert policy. "default" Required.
:param security_alert_policy_name: The name of the security alert policy. "Default" Required.
Copy link
Preview

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring has inconsistent capitalization. It shows "Default" instead of "default". Based on the pattern in other files that show "default", this should be "default" (lowercase) for consistency.

Suggested change
:param security_alert_policy_name: The name of the security alert policy. "Default" Required.
:param security_alert_policy_name: The name of the security alert policy. "default" Required.

Copilot uses AI. Check for mistakes.

@@ -276,7 +183,7 @@ async def create_or_update(
:param database_name: The name of the managed database for which the security alert policy is
defined. Required.
:type database_name: str
:param security_alert_policy_name: The name of the security alert policy. "default" Required.
:param security_alert_policy_name: The name of the security alert policy. "Default" Required.
Copy link
Preview

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring has inconsistent capitalization. It shows "Default" instead of "default". Based on the pattern in other files that show "default", this should be "default" (lowercase) for consistency.

Suggested change
:param security_alert_policy_name: The name of the security alert policy. "Default" Required.
:param security_alert_policy_name: The name of the security alert policy. "default" Required.

Copilot uses AI. Check for mistakes.

@@ -308,7 +215,7 @@ async def create_or_update(
:param database_name: The name of the managed database for which the security alert policy is
defined. Required.
:type database_name: str
:param security_alert_policy_name: The name of the security alert policy. "default" Required.
:param security_alert_policy_name: The name of the security alert policy. "Default" Required.
Copy link
Preview

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring has inconsistent capitalization. It shows "Default" instead of "default". Based on the pattern in other files that show "default", this should be "default" (lowercase) for consistency.

Suggested change
:param security_alert_policy_name: The name of the security alert policy. "Default" Required.
:param security_alert_policy_name: The name of the security alert policy. "default" Required.

Copilot uses AI. Check for mistakes.

@azure-sdk azure-sdk deleted the t2-sql-2025-07-29-33255 branch August 3, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants