Support distributed tracing in server sdk. #2186
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces activity tracing from app server to SignalR clients. The changes include creating and managing
Activityinstances to trace method calls and their outcomes, enhancing the observability of the service.Tracing Enhancements:
ServiceLifetimeManagerBase.cs: IntroducedActivitycreation and management for various methods likeSendAllAsync,SendAllExceptAsync,SendConnectionAsync, etc., and added a methodCreateActivityto initializeActivityinstances. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]ServiceLifetimeManager.cs: Updated methods likeSendConnectionAsyncandInvokeConnectionAsyncto create and startActivityinstances, and handle exceptions by setting error status and tags on theActivity. [1] [2]Method Signature Changes:
CreateMessagemethod inServiceLifetimeManager.cs: Added anActivityparameter to include tracing information in the message creation process. [1] [2]Dependency Additions:
System.DiagnosticsandMicrosoft.Azure.SignalR.Internalsnamespaces to support activity tracing. [1] [2]These changes aim to enhance the diagnostic capabilities of the Azure SignalR service by incorporating distributed tracing, making it easier to monitor and troubleshoot the service's behavior.