Skip to content

Ruby 3.0 removed URI.escape, CGI.escape should be used instead #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serprex wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ruby 3.0 removed URI.escape, CGI.escape should be used instead #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions table/lib/azure/storage/table/table_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.
#--------------------------------------------------------------------------
require "cgi"
require "azure/storage/table/auth/shared_key"

module Azure::Storage
Expand Down Expand Up @@ -234,7 +235,7 @@ def delete_table(table_name, options = {})
# * +:timeout+ - Integer. A timeout in seconds.
# * +:request_id+ - String. Provides a client-generated, opaque value with a 1 KB character limit that is recorded
# in the analytics logs when storage analytics logging is enabled.
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# which location the request should be sent to.
#
# Returns the last updated time for the table
Expand Down Expand Up @@ -263,7 +264,7 @@ def get_table(table_name, options = {})
# * +:timeout+ - Integer. A timeout in seconds.
# * +:request_id+ - String. Provides a client-generated, opaque value with a 1 KB character limit that is recorded
# in the analytics logs when storage analytics logging is enabled.
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# which location the request should be sent to.
# * +:accept+ - String. Specifies the accepted content-type of the response payload. Possible values are:
# :no_meta
Expand Down Expand Up @@ -306,7 +307,7 @@ def query_tables(options = {})
# * +:timeout+ - Integer. A timeout in seconds.
# * +:request_id+ - String. Provides a client-generated, opaque value with a 1 KB character limit that is recorded
# in the analytics logs when storage analytics logging is enabled.
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# which location the request should be sent to.
#
# See http://msdn.microsoft.com/en-us/library/azure/jj159100
Expand Down Expand Up @@ -412,7 +413,7 @@ def insert_entity(table_name, entity_values, options = {})
# * +:timeout+ - Integer. A timeout in seconds.
# * +:request_id+ - String. Provides a client-generated, opaque value with a 1 KB character limit that is recorded
# in the analytics logs when storage analytics logging is enabled.
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# which location the request should be sent to.
# * +:accept+ - String. Specifies the accepted content-type of the response payload. Possible values are:
# :no_meta
Expand Down Expand Up @@ -621,7 +622,7 @@ def delete_entity(table_name, partition_key, row_key, options = {})
# * +:timeout+ - Integer. A timeout in seconds.
# * +:request_id+ - String. Provides a client-generated, opaque value with a 1 KB character limit that is recorded
# in the analytics logs when storage analytics logging is enabled.
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# which location the request should be sent to.
#
# See http://msdn.microsoft.com/en-us/library/azure/dd894038
Expand Down Expand Up @@ -657,7 +658,7 @@ def execute_batch(batch, options = {})
# * +:timeout+ - Integer. A timeout in seconds.
# * +:request_id+ - String. Provides a client-generated, opaque value with a 1 KB character limit that is recorded
# in the analytics logs when storage analytics logging is enabled.
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# * +:location_mode+ - LocationMode. Specifies the location mode used to decide
# which location the request should be sent to.
#
# Returns an Azure::Storage::Table::Entity instance on success
Expand Down Expand Up @@ -746,7 +747,7 @@ def encodeODataUriValue(value)
value = value.gsub("'", "''")

# Encode the special URL characters
value = URI.escape(value)
value = CGI.escape(value)

value
end
Expand Down