Skip to content

Conversation

@polatengin
Copy link
Member

@polatengin polatengin commented Nov 20, 2025

Description

This PR contains formatting-only changes produced by running dotnet format to remove trailing whitespace, normalize line endings, and tidy up incidental spacing across the repository.

The edits are limited to whitespace and formatting cleanups (trimming trailing spaces and tabs, removing lines that contained only whitespace, collapsing accidental extra blank lines, and ensuring consistent newline characters in text files) and do not change any runtime logic or behavior.

Checklist

Microsoft Reviewers: Open in CodeFlow

…tespace across multiple files

- Cleaned up comments and removed trailing whitespace in various files.
- Ensured consistent formatting in Bicep decompiler integration tests and unit tests.
- Removed extra newlines and ensured proper line endings in JSON and YAML files.
- Updated project files to maintain consistent formatting and remove unnecessary whitespace.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Test this change out locally with the following install scripts (Action run 19556040654)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 19556040654
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 19556040654"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 19556040654
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 19556040654"

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Dotnet Test Results

   102 files   -     51     102 suites   - 51   38m 12s ⏱️ - 26m 32s
12 566 tests  -     13  12 566 ✅  -     13  0 💤 ±0  0 ❌ ±0 
28 877 runs   - 14 432  28 877 ✅  - 14 432  0 💤 ±0  0 ❌ ±0 

Results for commit f582bfa. ± Comparison against base commit a96acf3.

This pull request removes 1963 and adds 662 tests. Note that renamed tests count towards both.

		nestedProp1: 1
		nestedProp2: 2
		prop1: true
		prop2: false
	1
	2
	\$'")
	prop1: true
	prop2: false
…
Bicep.Cli.UnitTests.Services.ReplEnvironmentTests ‑ ShouldSubmitBuffer_terminates_at_expected_point ("var foo = {
")
Bicep.Cli.UnitTests.Services.ReplEnvironmentTests ‑ ShouldSubmitBuffer_terminates_at_expected_point ("var multilineString = '''
Line 1
Line 2
Line 3
'''")
Bicep.Cli.UnitTests.Services.ReplEnvironmentTests ‑ ShouldSubmitBuffer_terminates_at_expected_point ("var outRoleAssignments object[] = union(map(
  filter(varMockedEntraGroupIds, item => !contains(item.uniqueName, 'DevOps')),
  group => {
    principalId: group.groupId
    definition: group.roleToAssign
    relativeScope: ''
    principalType: 'Group'
  }
),[
  {
    principalId: '22222222-2222-2222-2222-222222222222'
    definition: 'Reader'
    relativeScope: ''
    principalType: 'ServicePrincipal'
  }
])")
Bicep.Cli.UnitTests.Services.ReplEnvironmentTests ‑ ShouldSubmitBuffer_terminates_at_expected_point ("var test = {
  abc: 'def' // boo
}")
Bicep.Cli.UnitTests.Services.ReplEnvironmentTests ‑ ShouldSubmitBuffer_terminates_at_expected_point ("var varMockedEntraGroupIds = [
  {
    uniqueName: 'Reader-Group'
    roleToAssign: 'Reader'
    groupId: '11111111-1111-1111-1111-111111111111'
  }
  {
    uniqueName: 'Contributor-Group'
    roleToAssign: 'Contributor'
    groupId: '22222222-2222-2222-2222-222222222222'
  }
  {
    uniqueName: 'DevOps-Group'
    groupId: '33333333-3333-3333-3333-333333333333'
  }
]")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��1
�@\u0010\u0005Щ=��\u00016���]#��\u00086\u001e`5#*&J�B@��`#��h,���f�\u000f���2�s	���v�q��O\u0003\u0000g�#\u0001�&P��{��H�4�K\u0017CK\u0000�'.�9��l�T��CwjF�D�q_ˌ�3n☍�9���_�M>��w����7��`xo��L`\u0000�� ������j�j�?�&J��z-�x�������ݒ$I\u0012��;�sY�\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
��=
�@\u0010\u0005�=�'X��Y-�S�
\u000b\u0011�k�J���\u0007R\u0005�4F\u000b�k^3Ń����}���3Z�f��\u0006\u0000��\u00040M@yr�\u001c�ґ\u00160t��\u0013@�d9���T
�\u001a�G0��
�-Ҧ?7u�NE\u000be\u0016����e�v�hV���?���X�\u001d�9\u0011ə�\u0010g)]d�ö��|�� ��(�\u0015�\u0001�\u001d��\u0000\u000c\u0000\u0000,"The path: index.json was not found in artifact contents")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000
���
�@\u0010\u0007�9�\u0014�\u000f�κ�N\u001bx\u0008:d�\u0005A�\u0010\u00142��\u000f\u0010z��K䥋\u0019��.s����?��%�*KҬ��6R{\u001c�����zVD�WĀz�D��u0��n�
\u0010a��aפ9�y�f\u001d?ח��g�h�"\u000b\u0005i�gZ\u0008ɵ1�+��z]k`����|̿�@\u0004\u0002���J\u0000��\u0000�Q2�N;�77�\u000f�M�<���؝3��glY�e�?�\u0003�eP�\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�ӽ
�0\u0014\u0005�;�\u0014�\u000f��4M�
�]\u0004\u0017\u001f �+Vl-���������|�Y�p�rd��ӊ}�]/5t\u0012K�4\u0000�i�H\u0000�	\u0018�rוּ$&���\u001f|G\u0000͓�E�cQ5%O��_�E��z�j.���f&ϔ�\u0013\u0018�l����=�N_�v�:%e\u0014��ZiCP�\u0002��lr����"�6<��\u001f�\s��.Z��?�|�w� \u0008����\u000eE3��\u0000\u000c\u0000\u0000,"Value cannot be null. (Parameter 'source')")
Bicep.Core.IntegrationTests.AzTypesViaRegistryTests ‑ Bicep_compiler_handles_corrupted_extension_package_gracefully (\u001f�\u0008\u0000\u0000\u0000\u0000\u0000\u0000\u0003�Ա
�0\u0010\u0006��}��\u0007H�4m.
\u000e���TAp�B\u0003*X�V(���ťV��������O�묞�,w�Rj�(��6\u00000q�L\u0000�\u0004\u0012n̳1�DM\u001d��Uv%��I
�%���C��Z\u001e�s1��8U��\u001b+6��dh�����\u001d�z]�e����|��\u0014�J\u0014��V:!(\u0000L��N����{0O���|�[lVi0\u0012�����<ϣ��\u0000n�\u000c�\u0000\u000c\u0000\u0000,"'7' is an invalid end of a number. Expected a delimiter. Path: $.INVALID_JSON | LineNumber: 0 | BytePositionInLine: 20.")
…

♻️ This comment has been updated with latest results.

@polatengin polatengin marked this pull request as draft November 20, 2025 19:31
@jeskew
Copy link
Member

jeskew commented Nov 20, 2025

dotnet format gets run weekly as a GitHub action. If there's some formatting that's not happening, we may need to add a line about it to .editorconfig in order to get it automatically applied in the next formatter run.

@polatengin polatengin marked this pull request as ready for review November 21, 2025 16:32
@polatengin
Copy link
Member Author

I couldn't make dotnet format to catch all, I've used this command to find trailing whitespaces;

grep -rn --exclude-dir={.git,.vscode-test,.turbo,node_modules,baselines,TestResults,bin,obj,out,dist} --exclude='*.bicep' --exclude='*.bicepparam' --exclude='*.gif' --exclude='*.svg' --exclude='*.png' --exclude='*.PNG' --exclude='local-tpn.txt' --exclude='*.jpg' --exclude='*.dll' --exclude='*.pdb' --exclude='*.xml' --exclude='*.resx' --exclude='*.so' --exclude='*.dylib' --exclude='*.Designer.cs' --exclude='*.binlog' --exclude='*.tgz' --exclude='Bicep.McpServer' --exclude='Bicep.LangServer' --exclude='*.ico' -P '[ \t]+$' .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants