Skip to content

Feature/Add JMX metrics #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Feature/Add JMX metrics #134

wants to merge 5 commits into from

Conversation

monishkadas-ms
Copy link
Collaborator

Configures custom JMX Metrics

Copilot
Copilot AI reviewed Feb 19, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/main/java/com/microsoft/azure/kusto/kafka/connect/sink/FileWriter.java:235

  • Verify that incrementing purgedOffset by the current value of flushedOffset is intentional; using a cumulative counter value may lead to misleading metric results.
purgedOffset.inc(flushedOffset.getCount());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@tanmaya-panda1 tanmaya-panda1 tanmaya-panda1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monishkadas-ms @tanmaya-panda1 @MonishkaDas