add arm64 support #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal allocations (TLS init, CallStack objects) from triggering recursion.
…ws ARM64's return addresses (from _ReturnAddress()) to match with function addresses in the stack trace by searching within a 4KB range instead of requiring an exact match.
…ions. The issue: if we're using RtlCaptureStackBackTrace's hash which includes all frames, but x64 matches context.fp at frame 5 and ARM64 doesn't match and defaults to frame 3, they'll have different hashes from RtlCaptureStackBackTrace even for identical call sites
mattdurak
reviewed
Jan 8, 2026
| @@ -0,0 +1,228 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested on x64 (locally) and on a remote ARM64 machine in Azure that all tests pass on DEBUG.
On RelWithDebInfo the same tests that failed on master are failing on this branch too.