Skip to content

Updated DesktopOsHelper.IsMac to work properly on net10 + macOS 26 #5541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated DesktopOsHelper.IsMac to work properly on net10 + macOS 26 #5541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/client/Microsoft.Identity.Client/PlatformsCommon/Shared/DesktopOsHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ public static bool IsMac()
return Environment.OSVersion.Platform == PlatformID.MacOSX;
#elif NET8_0_OR_GREATER
string OSDescription = RuntimeInformation.OSDescription;
return OSDescription.Contains("Darwin", StringComparison.OrdinalIgnoreCase);

// .NET 10 and later changes the OS string in `OSDescription`
return OSDescription.Contains("Darwin", StringComparison.OrdinalIgnoreCase) ||
Copy link

@cheenamalhotra cheenamalhotra Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View this comment as well: https://github.com/dotnet/runtime/pull/113041/files#r1985415935

You should be using RuntimeInformation.IsOSPlatform(OSPlatform.OSX) or OperatingSystem.IsMacOS() for .NET 10 onwards - maybe easier to handle it with if-def conditionally.

OSDescription.Contains("macOS", StringComparison.OrdinalIgnoreCase);
#else
return RuntimeInformation.IsOSPlatform(OSPlatform.OSX);
#endif
Expand Down