Mark API as experimental #5551
Open
Mark API as experimental #5551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MZOLN
approved these changes
Oct 24, 2025
| public ConfidentialClientApplicationBuilder WithClientAssertion(Func<AssertionRequestOptions, | ||
| CancellationToken, Task<ClientSignedAssertion>> clientSignedAssertionProvider) | ||
| { | ||
| ValidateUseOfExperimentalFeature(); |
There was a problem hiding this comment.
Do we have telemetry that this does not break anyone?
There was a problem hiding this comment.
mTLS POP is an internal only feature, so we should not be breaking anyone here.
There was a problem hiding this comment.
This doesn't seem to be limited to MTLS though is it?
There was a problem hiding this comment.
that's a good point @neha-bhargava and @trwalke. I will let @bgavrilMS know about this.
neha-bhargava
approved these changes
Oct 27, 2025
trwalke
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #- Mark API as experimental
Changes proposed in this request
This pull request refactors how client assertion delegates are registered in
ConfidentialClientApplicationBuilderand updates related unit tests to enable experimental features required for these APIs. The main change is the introduction of an internal helper method for setting client assertion providers, which improves code clarity and enforces experimental feature validation. The unit tests are updated to explicitly enable experimental features to ensure correct test coverage.Refactoring of client assertion registration:
WithClientAssertionInternalto encapsulate the logic for setting client assertion providers, and updated all publicWithClientAssertionoverloads to use this method. This also adds validation for the use of experimental features. (src/client/Microsoft.Identity.Client/AppConfig/ConfidentialClientApplicationBuilder.cs) [1] [2] [3] [4]Test updates for experimental feature usage:
.WithExperimentalFeatures(true)when usingWithClientAssertion, ensuring that tests reflect the required usage of experimental APIs. (tests/Microsoft.Identity.Test.Unit/PublicApiTests/ClientAssertionTests.cs,tests/Microsoft.Identity.Test.Unit/PublicApiTests/ConfidentialClientApplicationTests.cs) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Testing
Have unit, integration tests
Performance impact
none
Documentation