-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Implement redirect bridge to support COOP #8118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
konstantin-msft
wants to merge
55
commits into
msal-v5
Choose a base branch
from
popup_coop_support
base: msal-v5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,220
−1,358
Open
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
0e9e1c4
- Update popup client with a minimal functionality to handle popup CO…
konstantin-msft 8da953b
- Update popup client with a minimal functionality to handle popup CO…
konstantin-msft 9759da1
- Update popup client with a minimal functionality to handle popup CO…
konstantin-msft b785cbb
- Code size optimizations
konstantin-msft 125588f
- Code optimizations
konstantin-msft 7eb65d7
- Refactor silent client to use redirect bridge for both popup and SS…
konstantin-msft 1be20ef
- Refactor silent client to use redirect bridge for both popup and SS…
konstantin-msft d72ba13
Merge branch 'msal-v5' into popup_coop_support
konstantin-msft 2b46d6a
Update package-lock.json
konstantin-msft da8168d
- Update unit tests.
konstantin-msft f186235
Merge branch 'msal-v5' into popup_coop_support
konstantin-msft afae280
Fix post-merge errors.
konstantin-msft e7e5c54
Change files
konstantin-msft 40b8e3e
Add redirectBridgeEmptyResponse error code and update waitForBridgeRe…
konstantin-msft 2a28584
- Update redirect page for samples
konstantin-msft afe6890
- Remove redundant "unloadWindow" listener
konstantin-msft 240757c
Merge branch 'msal-v5' into popup_coop_support
konstantin-msft c3a5ed9
Merge branch 'msal-v5' of https://github.com/AzureAD/microsoft-authen…
lalimasharda a4c9ce5
Merge branch 'popup_coop_support' of https://github.com/AzureAD/micro…
lalimasharda 8a167fc
Merge branch 'msal-v5' of https://github.com/AzureAD/microsoft-authen…
lalimasharda 49b3506
- Add navigation to broadcastResponseToMainFrame
konstantin-msft 2895e20
- Add error description.
konstantin-msft 076df1d
- Resolve dep cycle
konstantin-msft 5cb8ca8
- Add support for overriding ongoing interactions in popup flows
konstantin-msft bb9480a
Merge branch 'msal-v5' into popup_coop_support
konstantin-msft 6636748
- Update core e2e tests
konstantin-msft 48e01bf
- Address review comments
konstantin-msft b42be72
- Update COOP migration guide
konstantin-msft 15086a0
- Update error doc
konstantin-msft 2780349
- Handle hybrid URL response format
konstantin-msft 4c1a103
Merge branch 'msal-v5' into popup_coop_support
konstantin-msft def925e
- Update migration doc
konstantin-msft 704968f
Merge branch 'msal-v5' into popup_coop_support
konstantin-msft 5ffe984
Update docs/errors.md
konstantin-msft ba93bd2
Update lib/msal-browser/docs/v4-migration.md
konstantin-msft f786341
Update lib/msal-browser/docs/v4-migration.md
konstantin-msft 7d7bdd3
Update lib/msal-browser/docs/v4-migration.md
konstantin-msft 0aadd91
Update lib/msal-browser/docs/v4-migration.md
konstantin-msft 4c73bbd
Update lib/msal-browser/docs/v4-migration.md
konstantin-msft 18b1e4f
- Pick up clientId from the session storage interaction key instead o…
konstantin-msft 348c75e
- Formatting
konstantin-msft d45e1d4
- Use `AuthError` to throw in the redirect bridge
konstantin-msft 2644d40
- Update API doc
konstantin-msft 25996a0
- Update e2e tests
konstantin-msft 48ba45d
Merge branch 'msal-v5' of https://github.com/AzureAD/microsoft-authen…
lalimasharda b58bd67
Merge branch 'popup_coop_support' of https://github.com/AzureAD/micro…
lalimasharda 9a7bd3d
- Update e2e tests
konstantin-msft ece3225
Merge remote-tracking branch 'origin/popup_coop_support' into popup_c…
konstantin-msft 9c32ec0
- Add visual examples on how to handle interaction override flag.
konstantin-msft a5572f0
- Update API doc
konstantin-msft cfef9f8
- Update redirect URI switch for express sample.
konstantin-msft be545c8
- Address review comments
konstantin-msft f5b340c
- Update API doc
konstantin-msft 7c088ed
- Increase version switch timeout for express sample
konstantin-msft 22be0a0
- Update redirect URI documentation
konstantin-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@azure-msal-browser-3b6b0844-0608-4d31-bba7-7c7177ad52f1.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "Implement redirect bridge to support COOP [#8118](https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/8118)", | ||
| "packageName": "@azure/msal-browser", | ||
| "email": "kshabelko@microsoft.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@azure-msal-common-cde5a6b6-5532-4445-945e-4ca192b96714.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "Implement redirect bridge to support COOP [#8118](https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/8118)", | ||
| "packageName": "@azure/msal-common", | ||
| "email": "kshabelko@microsoft.com", | ||
| "dependentChangeType": "patch" | ||
| } |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the default? And if user does not set this and we somehow lose the timeout from bridge, we expect the user to resend the request?
Whatever is the expected follow up, can we have this in the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overrideInteractionInProgressis described inlogin-user.md