Skip to content

Conversation

@tnorling
Copy link
Collaborator

Add comprehensive instructions for using GitHub Copilot with the MSAL.js repository, including build, testing, and validation guidelines.

Add comprehensive instructions for using GitHub Copilot with the MSAL.js repository, including build, testing, and validation guidelines.
@tnorling tnorling requested a review from a team as a code owner November 21, 2025 22:11
Copilot AI review requested due to automatic review settings November 21, 2025 22:11
Copilot finished reviewing on behalf of tnorling November 21, 2025 22:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive GitHub Copilot instructions to guide AI-assisted development and PR reviews in the MSAL.js repository. The documentation provides detailed guidance on building, testing, validating, and reviewing code within this monorepo.

Key Changes:

  • Added .github/copilot-instructions.md with build, testing, and validation workflows
  • Included telemetry and performance monitoring guidelines
  • Documented PR review checklist and code suggestion best practices

peterzenz
peterzenz previously approved these changes Nov 21, 2025
Added restrictions on instance aware flow usage and suggestions for alternatives.
Consolidate imports and update instructions for performance events.
### High-Level Repository Information

- **Type**: Monorepo with multiple npm packages using npm workspaces
- **Size**: Large repository with 140+ package.json files across packages and samples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this useful for copilot? Just curious.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, probably not useful. A lot of this was actually generated by Copilot and will likely need some refinement as it gets more use.

@tnorling tnorling enabled auto-merge (squash) December 2, 2025 22:22
@tnorling tnorling merged commit 1ebe2db into msal-v5 Dec 2, 2025
6 checks passed
@tnorling tnorling deleted the tnorling-patch-1 branch December 2, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants