Voxel shadow fixes for interleaved buffers #17376

MiiBond · 2025-10-31T18:27:49Z

This PR adds defines to assist with vertex pulling when the vertex buffers are interleaved.
I'm also including a fix by @Popov72 for IBL shadow voxelization when using bones.

bjsplat · 2025-10-31T18:29:23Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-10-31T18:30:48Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-10-31T18:45:21Z

Snapshot stored with reference name:
refs/pull/17376/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/17376/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/17376/merge
https://gui.babylonjs.com/?snapshot=refs/pull/17376/merge
https://nme.babylonjs.com/?snapshot=refs/pull/17376/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/17376/merge#BCU1XR#0

bjsplat · 2025-10-31T18:51:09Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-10-31T18:53:28Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-10-31T18:58:47Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-10-31T18:58:51Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgpuplaywright/index.html

packages/dev/core/src/ShadersWGSL/iblVoxelGrid.vertex.fx

bjsplat · 2025-10-31T22:08:52Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-10-31T22:10:52Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-10-31T22:11:23Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-10-31T22:11:30Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/devhostplaywright/index.html

MiiBond · 2025-11-07T19:33:00Z

@Popov72 I've included your fix and also made once that fixes the voxelization when calling it repeatedly.

This allows the voxelization to work with all the animated assets that I've tried.
Though, I suspect an animated asset that moves a lot will pass outside the bounds of the voxelization since the bounds update doesn't take skinning into account.

bjsplat · 2025-11-07T19:54:52Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/interactionplaywright/index.html

bjsplat · 2025-11-07T19:58:45Z

Devhost visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/devhostplaywright/index.html

bjsplat · 2025-11-07T20:04:41Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-11-07T20:06:44Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17376/merge/testResults/webgl2playwright/index.html

Popov72 · 2025-11-03T15:40:28Z

packages/dev/core/src/Materials/materialHelper.functions.ts

+        // Calculate offset in float32 elements
+        const offset = vertexBuffer.effectiveByteOffset / sizeInBytes;
+        defines[`${upperName}_OFFSET`] = offset;
+    }


"_COMPONENT_BYTES" is not set.

Changed to uniforms now.

Popov72 · 2025-11-03T15:47:35Z

packages/dev/core/src/Materials/shaderMaterial.ts

            }
+
+            // Add vertex buffer metadata defines for proper stride/offset handling
+            const geometry = renderingMesh.geometry;


I think you want to use the new PrepareDefinesForVertexPullingMetadata function instead?

Also, I think we should pass stride and offset as a byte count instead of a float count, to more easily handle all type conversions we will have to support (for example, type of position could be a (u)byte, (u)short, (u)int, float, and for the integer types, they could be normalized or not - these are type conversions we will have to perform in the shader).

Another thing is that we should probably use uniforms and not defines to pass data, else we will basically generate a new shader for each mesh, as (at least) offset will be different for each mesh.

Yup, good idea. I've changed to uniforms now.

sebavan · 2025-11-19T00:50:47Z

@MiiBond fyi cause I think some of the comments went in late :-)

bjsplat · 2025-11-21T21:37:32Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Popov72 · 2025-11-24T18:33:03Z

I didn't have time today, but I will review the PR tomorrow.

bjsplat · 2025-11-24T18:33:45Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Popov72 · 2025-11-25T17:04:10Z

You should remove package-lock.json from the PR.

Popov72 · 2025-11-25T17:27:17Z

packages/dev/core/src/Materials/materialHelper.functions.ts

+ * @param metadata The vertex pulling metadata
+ */
+export function BindVertexPullingUniforms(effect: Effect, metadata: Map<string, IVertexPullingMetadata>): void {
+    if (!metadata || !effect) {


If metadata and effect can be null/undefined, you should update their declaration in BindVertexPullingUniforms accordingly.

Popov72 · 2025-11-25T17:29:02Z

packages/dev/core/src/Materials/materialHelper.functions.ts

+    for (const [attribute, data] of metadata.entries()) {
+        const uniformName = `vp_${attribute}_info`;
+        // Pack into vec3: (offset, stride, type)
+        effect.setVector3(uniformName, new Vector3(data.offset, data.stride, data.type));


You should use setFloat3 to avoid creating a new Vector3 for each attribute every frame (you could also use setInt3, if ints are easier to handle than floats in the shader).

Popov72 · 2025-11-25T17:42:17Z

packages/dev/core/src/Materials/shaderMaterial.ts

+            // Add vertex buffer metadata defines for proper stride/offset handling
+            const geometry = renderingMesh.geometry;
+            if (geometry) {
+                this._vertexPullingMetadata = PrepareVertexPullingUniforms(geometry);


You should normally update the uniforms array passed to createEffect with the names of the new uniforms. I'm not sure why it works without this code...

Popov72 · 2025-11-25T17:44:01Z

packages/dev/core/src/ShadersWGSL/iblVoxelGrid.vertex.fx

-  pos.y = position[index * 3 + 1];
-  pos.z = position[index * 3 + 2];
-  return pos;
+uniform vp_position_info: vec3f; // (bufferIndex, offset, stride, type)


I'm not sure what bufferIndex refers to?

MiiBond commented Oct 31, 2025

View reviewed changes

packages/dev/core/src/ShadersWGSL/iblVoxelGrid.vertex.fx Outdated Show resolved Hide resolved

deltakosh requested a review from Popov72 November 1, 2025 00:15

MiiBond force-pushed the mbond/voxel-shadow-fixes branch from 1cee238 to ce4c445 Compare November 7, 2025 19:31

Popov72 reviewed Nov 10, 2025

View reviewed changes

Mike Bond and others added 7 commits November 21, 2025 12:52

Fix for vertex pulling of interleaved buffers

df7868e

Fix bones when using vertex pulling

719cc5b

Fix vertex type in voxel shadows

8d17560

Trying to get skinned meshes working with voxelization

cd0ae8d

Fix wrong shadows with morphs

61f7e37

Fix for multiple voxelization calls at once

3d8897e

Handle vertex pulling of different data type

33b07ed

MiiBond force-pushed the mbond/voxel-shadow-fixes branch from ce4c445 to 33b07ed Compare November 21, 2025 20:57

Cleanup and fixes

437c627

Popov72 reviewed Nov 25, 2025

View reviewed changes

Voxel shadow fixes for interleaved buffers #17376

Are you sure you want to change the base?

Voxel shadow fixes for interleaved buffers #17376

Uh oh!

Conversation

MiiBond commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

bjsplat commented Oct 31, 2025

Uh oh!

MiiBond commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjsplat commented Nov 7, 2025

Uh oh!

bjsplat commented Nov 7, 2025

Uh oh!

bjsplat commented Nov 7, 2025

Uh oh!

bjsplat commented Nov 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sebavan commented Nov 19, 2025

Uh oh!

bjsplat commented Nov 21, 2025

Uh oh!

Popov72 commented Nov 24, 2025

Uh oh!

bjsplat commented Nov 24, 2025

Uh oh!

Popov72 commented Nov 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MiiBond commented Nov 7, 2025 •

edited

Loading