Skip to content

Conversation

@ryantrem
Copy link
Member

@ryantrem ryantrem commented Nov 4, 2025

This is addressing an Inspector v2 forum ask: https://forum.babylonjs.com/t/introducing-inspector-v2/60937/85

It adds more details to extension metadata and displays it in the extensions dialog. It also makes it more clear at a glance whether an extension is currently installed. There is also some general style improvements, like using the Fluent Card component which is made for this type of use case.

image image image image

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Extensions List UI by adding richer metadata display including author/contributor information, web resources (homepage, repository, bugs), version/license details, and improved visual design with cards and badges. It also implements dynamic importing for the extension list service to improve initial load performance.

Key Changes

  • Enhanced extension metadata type with author, contributors, version, license, homepage, repository, and bugs fields
  • Redesigned the extensions UI with Card components, presence badges for installed extensions, and improved information display
  • Added dynamic import for ExtensionListServiceDefinition to optimize bundle size

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
packages/dev/inspector-v2/src/services/extensionsListService.tsx Refactored UI to use Card-based layout, added author/contributor display with popovers, web resource links, and moved accordion structure into ExtensionDetails component
packages/dev/inspector-v2/src/modularTool.tsx Changed ExtensionListServiceDefinition import to dynamic import for code splitting
packages/dev/inspector-v2/src/extensibility/extensionFeed.ts Added PersonMetadata type and extended ExtensionMetadata with additional optional fields (version, license, homepage, repository, bugs, author, contributors)
packages/dev/inspector-v2/src/extensibility/defaultInspectorExtensionFeed.ts Added BabylonWebResources constant and applied it with author information to built-in extensions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17389/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17389/merge/?snapshot=refs/pull/17389/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17389/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

@deltakosh deltakosh enabled auto-merge (squash) November 4, 2025 17:31
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17389/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17389/merge/?snapshot=refs/pull/17389/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17389/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 4, 2025

@deltakosh deltakosh merged commit 2c784ce into BabylonJS:master Nov 4, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants