close CacheStore in CacheManager.dispose and cancel internal timer #418
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contactjavas
added a commit
to tentram/flutter_cache_manager
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug Fix
When closing the
CacheManager(using whatever state management or manuallyProvider,Bloc,Riverpod, etc) and the internal clean up schedule timer of the store is still running there is an Exception thrown by theCacheInfoRepositoryif its implemented by an SQL/NoSQL package (Hivefor example) because it tries to use a repository that is already closed🆕 What is the new behavior (if this is a feature change)?
CacheManager closes the internal store and by doing that, the store closes the repository used and also stops the timer in case it's running
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
Close the cacheManager after using it
📝 Links to relevant issues/docs
🤔 Checklist before submitting