Add error handling to cache store future operations #499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
When database operations in the
retrieveCacheDatamethod encounter exceptions, error callbacks are not properly executed. Specifically:_getCacheDataFromDatabaseor related async operations throw exceptions, theCompleteris not handled correctly_futureCachemay not be properly cleaned up, causing memory leaks🆕 What is the new behavior (if this is a feature change)?
After the fix:
catchErrorhandler to properly catch and propagate exceptions to thecompleter_futureCachein both success and error paths💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
_fileExistsmethod throws exceptions_cacheInfoRepositoryaccess fails_futureCacheis properly cleaned up in exception cases📝 Links to relevant issues/docs
N/A
🤔 Checklist before submitting