create archived folder and august release bundle #22
Conversation
PR Reviewer Guide 🔍(Review updated until commit c3a422a)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to c3a422a
Previous suggestions✅ Suggestions up to commit 6fd3aa7
✅ Suggestions up to commit 6fd3aa7
✅ Suggestions up to commit 56931c0
Suggestions up to commit acb31a5
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@N6REJ , can you look at the recommendations provided by the AI. Looks like some config file changes are substantial and potentially breaking to how we have released in the past. |
…ons and add innodb_redo_log_capacity
![qodo-merge-pro[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
|
|
||
| # mysql-native-password setting removed for MySQL 9.4.0 (unknown variable in 9.x) | ||
| character-set-server=UTF8MB4 |
There was a problem hiding this comment.
Suggestion: Eliminate unsupported config option
| # mysql-native-password setting removed for MySQL 9.4.0 (unknown variable in 9.x) | |
| character-set-server=UTF8MB4 | |
| default_authentication_plugin=mysql_native_password | |
| character-set-server=UTF8MB4 |
|
Persistent suggestions updated to latest commit 6fd3aa7 |
… MySQL 9.4.0 configuration
| #innodb_lock_wait_timeout = 50 | ||
| # In bin/mysql9.4.0/my.ini | ||
| # (skip-federated and innodb_log_file_size are removed in MySQL 8.4+, | ||
| # so they should be deleted, not commented out. | ||
| # innodb_redo_log_capacity should be used instead of innodb_log_file_size if needed) | ||
| innodb_redo_log_capacity = 10M # Example value | ||
|
|
||
| sql_mode=NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO | ||
| default_authentication_plugin=mysql_native_password | ||
|
|
||
| mysql-native-password=ON | ||
| character-set-server=UTF8MB4 |
There was a problem hiding this comment.
Suggestion: Remove invalid auth option
| #innodb_lock_wait_timeout = 50 | |
| # In bin/mysql9.4.0/my.ini | |
| # (skip-federated and innodb_log_file_size are removed in MySQL 8.4+, | |
| # so they should be deleted, not commented out. | |
| # innodb_redo_log_capacity should be used instead of innodb_log_file_size if needed) | |
| innodb_redo_log_capacity = 10M # Example value | |
| sql_mode=NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO | |
| default_authentication_plugin=mysql_native_password | |
| mysql-native-password=ON | |
| character-set-server=UTF8MB4 | |
| #innodb_lock_wait_timeout = 50 | |
| # (skip-federated and innodb_log_file_size are removed in MySQL 8.4+; | |
| # innodb_redo_log_capacity should be used instead of innodb_log_file_size if needed) | |
| innodb_redo_log_capacity = 10M | |
| sql_mode=NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO | |
| character-set-server=UTF8MB4 |
| # In bin/mysql9.4.0/my.ini | ||
| # (skip-federated and innodb_log_file_size are removed in MySQL 8.4+, | ||
| # so they should be deleted, not commented out. | ||
| # innodb_redo_log_capacity should be used instead of innodb_log_file_size if needed) | ||
| innodb_redo_log_capacity = 10M # Example value | ||
|
|
||
| sql_mode=NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO | ||
| default_authentication_plugin=mysql_native_password | ||
|
|
||
| mysql-native-password=ON | ||
| character-set-server=UTF8MB4 |
There was a problem hiding this comment.
Suggestion: Remove unsupported auth option
| # In bin/mysql9.4.0/my.ini | |
| # (skip-federated and innodb_log_file_size are removed in MySQL 8.4+, | |
| # so they should be deleted, not commented out. | |
| # innodb_redo_log_capacity should be used instead of innodb_log_file_size if needed) | |
| innodb_redo_log_capacity = 10M # Example value | |
| sql_mode=NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO | |
| default_authentication_plugin=mysql_native_password | |
| mysql-native-password=ON | |
| character-set-server=UTF8MB4 | |
| # (skip-federated and innodb_log_file_size are removed in MySQL 8.4+; | |
| # innodb_redo_log_capacity should be used instead of innodb_log_file_size if needed) | |
| innodb_redo_log_capacity = 10M | |
| sql_mode=NO_ENGINE_SUBSTITUTION,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO | |
| character-set-server=UTF8MB4 |
…og_capacity to 256M and remove mysql-native-password option
|
Ready to release |
2 participants
PR Type
Other
Description
Archive old MySQL versions to archived folder
Remove deprecated
default_authentication_pluginfrom configurationsAdd
innodb_redo_log_capacityfor MySQL 8.4+ versionsUpdate release bundle to August 2025
Diagram Walkthrough
File Walkthrough
16 files
Remove MySQL 5.7.39 init scriptRemove MySQL 8.0.27 init scriptRemove MySQL 8.0.29 init scriptRemove MySQL 8.0.36 init scriptRemove MySQL 8.0.37 init scriptRemove MySQL 8.0.41 init scriptRemove MySQL 8.0.42 init scriptRemove MySQL 8.3.0 init scriptRemove entire MySQL 5.7.39 configurationRemove entire MySQL 5.7.39 configuration backupRemove MySQL 8.0.29 bearsampp configurationRemove entire MySQL 8.0.29 configurationRemove entire MySQL 8.0.29 configuration backupRemove MySQL 8.0.30 bearsampp configurationRemove MySQL 8.0.31 bearsampp configurationRemove entire MySQL 8.0.31 configuration4 files
Remove deprecated authentication plugin settingRemove deprecated authentication plugin settingRemove deprecated authentication plugin settingRemove deprecated authentication plugin setting38 files