fix: helm migration job not running schema update #12809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of the specification is important here, k8s will take the last value as truth. Push down to be sure schema update is done by migration job
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
The order of
DISABLE_SCHEMA_UPDATEis important here, k8s will take the last value as truth. Push down to be sure schema update is done by migration job as best practices suggest to set this for litellm pods and will now be included into the migration job by #12591https://docs.litellm.ai/docs/proxy/prod#7-use-helm-presync-hook-for-database-migrations-beta
When a key exists in multiple sources, the value associated with the last source will take precedence.https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#environment-variables
Relevant issues
#12591
Pre-Submission checklist
Type
🐛 Bug Fix
🚄 Infrastructure
Changes
Push
DISABLE_SCHEMA_UPDATE: falseto the bottom of env vars to ensure it is always false for the migration job and schema is being updated