Upgrades BAP to janestreet v0.17 libraries (and OCaml 5) #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmourad01
force-pushed
the
upgrade-janestreet-17
branch
from
0c76ad8 to
65c282d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the branch to upgrade BAP to janestreet v0.16 libraries as seen in #1602.
There are a few notable changes:
bap-piqiand the associated plugin, as thepiqipackage is currently not compatible with OCaml 5.pp_set_formatter_tag_functionsinFormathas been removed as of OCaml 5 (this affects thetext-tagspackage, mainly). It has been replaced withpp_set_formatter_stag_functions(see here).effecttoeffect_, in order to cope with the fact that this has been claimed as a keyword for syntactic support for deep effect handlers.