feat: Replace Generic Errors with Suspicious Transaction Errors for UTXO/EthLike Coins #7236
+207
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikpopov164
previously requested changes
Oct 14, 2025
There was a problem hiding this comment.
Not sure if this task can be done before the #7148 is merged
lcovar
previously approved these changes
Oct 14, 2025
danielpeng1
force-pushed
the
WP-6189/introduce-suspicious-transaction-errors
branch
from
84a5fa8 to
4714aa6
Compare
danielpeng1
force-pushed
the
WP-6189/introduce-suspicious-transaction-errors
branch
from
83c2b6d to
b05154e
Compare
danielpeng1
force-pushed
the
WP-6189/introduce-suspicious-transaction-errors
branch
from
b05154e to
4ed51a7
Compare
lcovar
previously approved these changes
Oct 17, 2025
OttoAllmendinger
requested changes
Oct 20, 2025
modules/abstract-utxo/src/transaction/fixedScript/verifyTransaction.ts
Outdated
Show resolved
Hide resolved
danielpeng1
force-pushed
the
WP-6189/introduce-suspicious-transaction-errors
branch
from
4ed51a7 to
6e7a8b7
Compare
OttoAllmendinger
requested changes
Oct 20, 2025
modules/abstract-utxo/src/transaction/fixedScript/verifyTransaction.ts
Outdated
Show resolved
Hide resolved
modules/abstract-utxo/src/transaction/fixedScript/verifyTransaction.ts
Outdated
Show resolved
Hide resolved
modules/abstract-utxo/src/transaction/fixedScript/verifyTransaction.ts
Outdated
Show resolved
Hide resolved
modules/abstract-utxo/src/transaction/fixedScript/verifyTransaction.ts
Outdated
Show resolved
Hide resolved
modules/abstract-utxo/src/transaction/fixedScript/verifyTransaction.ts
Outdated
Show resolved
Hide resolved
modules/abstract-utxo/src/transaction/fixedScript/verifyTransaction.ts
Outdated
Show resolved
Hide resolved
modules/abstract-utxo/src/transaction/fixedScript/verifyTransaction.ts
Outdated
Show resolved
Hide resolved
OttoAllmendinger
requested changes
Oct 21, 2025
lcovar
force-pushed
the
WP-6189/introduce-suspicious-transaction-errors
branch
from
7780623 to
ba77be2
Compare
lcovar
force-pushed
the
WP-6189/introduce-suspicious-transaction-errors
branch
2 times, most recently
from
6be4d8d to
28a7df1
Compare
Replace custom validation errors with SDK's TxIntentMismatchRecipientError to provide more detailed information about mismatched transaction outputs. This enhances error reporting by including specific details about missing or unexpected outputs, helping users understand what differs between their intent and the actual transaction. Co-authored-by: llm-git <llm-git@ttll.de> Ticket: BTC-2579 TICKET: WP-6189
lcovar
force-pushed
the
WP-6189/introduce-suspicious-transaction-errors
branch
from
28a7df1 to
3a9d500
Compare
OttoAllmendinger
previously approved these changes
Oct 22, 2025
lcovar
approved these changes
Oct 22, 2025
mohammadalfaiyazbitgo
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace generic Error throws with
TxIntentMismatchErrorinverifyTransactionmethods for Bitcoin and other UTXO & EthLike coins to provide more specific error handling for suspicious transaction detection.verifyTransactionmethodsverifyTransactionmethodsOpen to comments relating to copy or if I've missed any generic error.
Ticket: WP-6189