feat(sdk-core): add AddressQueryResult typing for addresses #7305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadalfaiyazbitgo
force-pushed
the
WP-6403/add-address-typing
branch
from
c4cfb93 to
3ffc05d
Compare
- Update @bitgo/public-types from 5.31.0 to 5.34.0 across all packages - sdk-core - sdk-coin-sol - express - bitgo - abstract-lightning - Import and apply AddressQueryResult type to addresses() method in Wallet class and IWallet interface - Update addresses() return type from Promise<any> to Promise<AddressQueryResult> This change improves type safety for the /api/v2/{coin}/wallet/{walletId}/addresses endpoint and ensures proper typing for address query responses across the SDK. TICKET: WP-6403
mohammadalfaiyazbitgo
force-pushed
the
WP-6403/add-address-typing
branch
from
3ffc05d to
f3dec74
Compare
mukeshsp
approved these changes
Oct 23, 2025
Marzooqa
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves type safety for the /api/v2/{coin}/wallet/{walletId}/addresses endpoint and ensures proper typing for address query responses across the SDK.
TICKET: WP-6403