Skip to content

Initial DOM data structure #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BrianBorge wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Initial DOM data structure #1

BrianBorge wants to merge 4 commits into from

Conversation

@BrianBorge
Copy link
Owner

@BrianBorge BrianBorge commented Jun 5, 2020 •
edited
Loading

The DOM

  • The DOM is a tree of nodes 🌲 , so we will need to represent a node. oh, and a node can have child nodes.
  • We also need some node types
    • Text and Element to start and maybe Comment

To Do

  • Create a node
  • Create node types
  • Create the DOM
  • Add tests! (requires setting up a test suite)

Resources

  1. https://limpet.net/mbrubeck/2014/08/08/toy-layout-engine-1.html
  2. https://dom.spec.whatwg.org/
  3. https://dom.spec.whatwg.org/#dom-node-nodetype

@BrianBorge BrianBorge self-assigned this Jun 5, 2020
BrianBorge
BrianBorge commented Jun 5, 2020
View reviewed changes
node_types.rb Outdated
@@ -0,0 +1,18 @@
module NodeTypes
class Text
Copy link
Owner Author

@BrianBorge BrianBorge Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should node types inherit from Node?

BrianBorge
BrianBorge commented Jun 5, 2020
View reviewed changes
dom.rb Outdated
require_relative 'node'
require_relative 'node_types'

class Dom
Copy link
Owner Author

@BrianBorge BrianBorge Jun 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably consider wrapping all the code in a WindowBrowser module.

@BrianBorge
wip:
4d64465 
- organize project folder structure
- NodeTypes inherit from Node
- wrap all the code in a WindowBrowser module
- Add some node methods:
  - first_child: fetch the node's first child
  - children?: fetch the node's children
  - type: fetch the node's type (e.g. WindowBrowser::NodeTypes::Element)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BrianBorge BrianBorge

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrianBorge